fix: Handle Nullable Map and Enum Mismatch in MarkTextOptions.kt #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle Nullable Map and Enum Mismatch in MarkTextOptions.kt
Description
This PR addresses two issues in
MarkTextOptions.kt
:Nullable
ReadableMap
handlingReadableArray.getMap(index)
returns a nullableReadableMap?
, but was passed directly into theTextOptions
constructor, which expects a non-nullReadableMap
.✅ Fixed using Kotlin's safe call with
let { ... }
, and explicitly throwingMarkerError
if null.Incorrect enum usage
MarkerError
expects the first argument to be of typeErrorCode
, but aString
literal"NULL_MAP"
was passed instead.✅ Fixed by adding a new
ErrorCode.NULL_MAP
enum value and using it explicitly in the constructor.Changes
ErrorCode.NULL_MAP
to theErrorCode
enum.MarkTextOptions.kt
to:ReadableArray
.MarkerError(ErrorCode.NULL_MAP, ...)
instead of passing a raw string.Impact
NullPointerException
during runtime.Test
watermarkTexts
input