Skip to content

Fix StackOverflowException in ZhangSuenSkeletonization for large images #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jmerk523 wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix StackOverflowException in ZhangSuenSkeletonization for large images #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
585d495
Fix StackOverflowException in ZhangSuenSkeletonization for large images
Jmerk523 Apr 27, 2019
26b2c46
Correct using statement ordering
Jmerk523 Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 44 additions & 30 deletions Sources/Accord.Imaging/AForge.Imaging/Filters/Other/ZhangSuenSkeletonization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,12 @@ namespace Accord.Imaging.Filters
{
using Accord.Imaging;
using Accord.Imaging.Filters;
using System;
using System.Collections.Generic;
using System.Drawing;
using System.Drawing.Imaging;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

/// <summary>
/// Zhang-Suen skeletonization filter.
Expand Down Expand Up @@ -150,39 +153,50 @@ protected override unsafe void ProcessFilter(UnmanagedImage source, UnmanagedIma

// do the job
var dst0 = (byte*)destination.ImageData.ToPointer();
var del0 = stackalloc byte[delSize]; for (var i = 0; i < delSize; i++) del0[i] = 0xFF;

bool endOfAlgorithm;
IntPtr delPtr = IntPtr.Zero;
RuntimeHelpers.PrepareConstrainedRegions();
try
{
delPtr = Marshal.AllocHGlobal(delSize);
var del0 = (byte*)delPtr.ToPointer(); for (var i = 0; i < delSize; i++) del0[i] = 0xFF;

bool endOfAlgorithm;

do
do
{
endOfAlgorithm = true;

// Setp 1
Process(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstStride, dstOffset,
del0,
new[] { 1, 3, 5, 3, 5, 7 },
ref endOfAlgorithm);

// Deletion
delete(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstOffset,
del0);

// Setp 2
Process(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstStride, dstOffset,
del0,
new[] { 1, 3, 7, 1, 5, 7 },
ref endOfAlgorithm);

// Deletion
delete(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstOffset,
del0);

} while (!endOfAlgorithm);
}
finally
{
endOfAlgorithm = true;

// Setp 1
Process(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstStride, dstOffset,
del0,
new[] { 1, 3, 5, 3, 5, 7 },
ref endOfAlgorithm);

// Deletion
delete(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstOffset,
del0);

// Setp 2
Process(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstStride, dstOffset,
del0,
new[] { 1, 3, 7, 1, 5, 7 },
ref endOfAlgorithm);

// Deletion
delete(startX, startY, stopX, stopY,
dst0 + (rect.Top + 1) * dstStride + rect.Left + 1, dstOffset,
del0);

} while (!endOfAlgorithm);
Marshal.FreeHGlobal(delPtr);
}

#region Set colors

Expand Down