Skip to content

Remove unused generatePersonsBatched function#7

Draft
Copilot wants to merge 5 commits intomainfrom
copilot/sub-pr-6
Draft

Remove unused generatePersonsBatched function#7
Copilot wants to merge 5 commits intomainfrom
copilot/sub-pr-6

Conversation

Copy link

Copilot AI commented Dec 27, 2025

Addresses review feedback from PR #6 identifying an unused async generator function.

Changes

  • Removed generatePersonsBatched function (257-276) from src/webapp/data/fake-persons.ts

The function was a batched generator for memory-efficient person generation but was never called. The simpler generatePersons function covers all current use cases.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 27, 2025
Co-authored-by: JohannesKonings <14806640+JohannesKonings@users.noreply.github.com>
@JohannesKonings
Copy link
Owner

@copilot rebase

Copilot AI changed the title [WIP] Address feedback on tanstack db and DynamoDB example Remove unused generatePersonsBatched function Dec 27, 2025
Copy link
Author

Copilot AI commented Dec 27, 2025

@copilot rebase

I cannot perform a rebase because force push is not available in my environment. However, I can see that the base branch (tanstack-db-persons) already has a cleanup commit (d1d4992) that removed the generatePersonsBatched function along with other unused utility functions.

Since the base branch already includes the changes from this PR, you have two options:

  1. Close this PR as the changes are already in the base branch
  2. Manually rebase this branch locally using: git fetch origin && git rebase origin/tanstack-db-persons && git push --force-with-lease

Base automatically changed from tanstack-db-persons to main December 27, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants