Draft
Conversation
Co-authored-by: JohannesKonings <14806640+JohannesKonings@users.noreply.github.com>
Owner
|
@copilot rebase |
Copilot
AI
changed the title
[WIP] Address feedback on tanstack db and DynamoDB example
Remove unused generatePersonsBatched function
Dec 27, 2025
Author
I cannot perform a rebase because force push is not available in my environment. However, I can see that the base branch ( Since the base branch already includes the changes from this PR, you have two options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #6 identifying an unused async generator function.
Changes
generatePersonsBatchedfunction (257-276) fromsrc/webapp/data/fake-persons.tsThe function was a batched generator for memory-efficient person generation but was never called. The simpler
generatePersonsfunction covers all current use cases.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.