pull

[John75SunCity]

No description provided.

[John75SunCity]

reviewed

[Copilot]

Pull Request Overview

This PR adds a validation script for XML/Python files, introduces new portal and inventory templates for the records management module, updates sample tag data and manifest dependencies, and adjusts the devcontainer configuration.

• Add validate_module.py for basic XML and Python syntax checks
• Create portal view in my_portal_inventory.xml and standalone inventory template in inventory_template.xml
• Replace tag model stub with sample tag_data.xml, add sale dependency, and clean up .devcontainer/devcontainer.json

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
validate_module.py	New script to walk a module path and validate XML/Python files
records_management/views/my_portal_inventory.xml	Portal extension to display inventory link on customer portal
records_management/views/inventory_template.xml	Standalone inventory template with table of quants
records_management/data/tag_data.xml	Replace initial model registration with sample tag records
records_management/manifest.py	Add sale to dependencies and switch to data/tag_data.xml
.devcontainer/devcontainer.json	Comment out extensions and mounts, introduce JSON structure issues

Comments suppressed due to low confidence (2)

records_management/views/inventory_template.xml:9

• [nitpick] The template uses quants, while the portal version uses inventory_records. Consider standardizing variable names across templates for clarity.

                        <div t-if="not quants" class="alert alert-info">

.devcontainer/devcontainer.json:74

• The JSON structure is broken after commenting out the mounts and closing braces; this will cause a syntax error. Please validate the file and restore matching { } or remove trailing commas.

  "remoteEnv": {

[Copilot]

Avoid hard-coding module_path. Consider using an argument parser (e.g., argparse) or environment variable to allow configuring the path at runtime.

[Copilot]

The file-discovery logic in validate_xml_files and validate_python_files is duplicated. Extract a helper (e.g., find_files(module_path, extension)) to reduce repetition.

Suggested change

	def validate_xml_files(module_path):
	"""Validate XML files in the module"""
	xml_files = []
	# Find all XML files
	for root, dirs, files in os.walk(module_path):
	for file in files:
	if file.endswith('.xml'):
	xml_files.append(os.path.join(root, file))
	def find_files(module_path, extension):
	"""Find files with the given extension in the specified module path"""
	files = []
	for root, dirs, files_in_dir in os.walk(module_path):
	for file in files_in_dir:
	if file.endswith(extension):
	files.append(os.path.join(root, file))
	return files
	def validate_xml_files(module_path):
	"""Validate XML files in the module"""
	xml_files = []
	# Find all XML files
	xml_files = find_files(module_path, '.xml')

[Copilot]

Replace print statements with the logging module to give users configurable log levels and better integration in other scripts.

Suggested change

	print(f"Found {len(xml_files)} XML files")
	for xml_file in xml_files:
	try:
	ET.parse(xml_file)
	print(f"✓ {xml_file} - Valid XML")
	except ET.ParseError as e:
	print(f"✗ {xml_file} - Parse Error: {e}")
	except Exception as e:
	print(f"✗ {xml_file} - Error: {e}")
	logging.info(f"Found {len(xml_files)} XML files")
	for xml_file in xml_files:
	try:
	ET.parse(xml_file)
	logging.info(f"✓ {xml_file} - Valid XML")
	except ET.ParseError as e:
	logging.error(f"✗ {xml_file} - Parse Error: {e}")
	except Exception as e:
	logging.error(f"✗ {xml_file} - Error: {e}")