pull #7
Merged
pull #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new HTML file for the Records Management module. - Included an overview of features, usage instructions, and support contact. - Added placeholder for screenshots and icons in the static description directory.
… the dependencies list
… to include missing commas
… and ensuring proper structure
…ng 'installable' and 'application' fields are properly set
…g syntax and ensuring consistent use of triple quotes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Odoo module for records management that streamlines the handling of pickup requests, shredding services, and inventory tracking.
- Adds Python models, controllers, and XML views/templates to support record management and service operations.
- Configures module security, assets (CSS/JS), and Docker deployment details, and provides documentation.
Reviewed Changes
Copilot reviewed 19 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| records_management/init.py | Initializes module imports for models and controllers. |
| records_management-1/views/scrm_records_management_views.xml | Defines basic UI views for pickup requests and shredding services. |
| records_management-1/views/scrm_records_management_templates.xml | Provides alternative UI templates with additional controls (footer buttons) for pickup requests. |
| records_management-1/views/assets.xml | Includes CSS and JS assets related to records management. |
| records_management-1/static/src/js/scrm_records_management.js | Implements JavaScript functionality for pickup request submission and error handling. |
| records_management-1/security/*.xml & *.csv | Sets up security groups and access rights for module objects. |
| records_management-1/models/scrm_records_management.py | Contains model definitions and business logic for shredding services and pickup requests. |
| records_management-1/controllers/scrm_records_management_controller.py | Provides HTTP routes and controller logic for inventory and request pickup views. |
| docker-compose.yml | Updates service definitions to use a newer Odoo version and improved volume documentation. |
| README.md | Documents module overview, installation, usage, and additional resources. |
Comments suppressed due to low confidence (2)
records_management-1/views/scrm_records_management_templates.xml:1
- Duplicate view record IDs (e.g. 'view_pickup_request_form' and 'view_pickup_request_tree') are defined in both scrm_records_management_views.xml and scrm_records_management_templates.xml. Consider consolidating these definitions or using unique IDs to prevent potential conflicts.
<record id="view_pickup_request_form" model="ir.ui.view">
records_management-1/static/src/js/scrm_records_management.js:42
- The variable 'session' is used in the RPC call without being defined in this scope. Ensure 'session' is correctly imported or retrieved so that partner_id is available.
args: [session.partner_id, itemIds],
John75SunCity
added a commit
that referenced
this pull request
Aug 7, 2025
- Removed manual mail.thread field definitions (activity_ids, message_follower_ids, message_ids)
- Removed compute methods with @api.depends('id') which is not allowed in Odoo
- Mail.thread inheritance provides these fields automatically
- Fixes NotImplementedError: Compute method cannot depend on field 'id'
- Continues systematic runtime error resolution - Error #7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull it