Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install instructions and update method name #1

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

ash-jc-allen
Copy link
Contributor

Hey @JonPurvis, I love the new package! I'm going to be installing it in my own projects 😄

I was just giving it a spin before I wrote a blog post about it, and I noticed a couple of things in the docs. There didn't seem to be any instructions on how to install the package. And I think the method name mentioned didn't seem to be the same as the one in the plugin's code.

I've updated both of these (hopefully correctly). But please feel free to close the PR if you don't think these changes are needed! 😄

@JonPurvis
Copy link
Owner

Hey @ash-jc-allen 👋

Thanks for checking it out and thanks for sorting out some really simple stuff I missed 😆

The method name in the readme was actually what it was originally going to be called, before I changed my mind 😆 I forgot I had it referenced in the docs. I'll get this PR merged!

@JonPurvis JonPurvis merged commit da9e5b8 into JonPurvis:master Aug 4, 2024
20 checks passed
@ash-jc-allen
Copy link
Contributor Author

Hey, it's no problemo, I'm glad I could lend a hand!

And I had a feeling that was the case with the naming. I do it all the time haha 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants