-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/ws-reconnect-on-dev-shut-down #852
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm dev
doesn't run becauseSIGKILL
signal is not available on POSIX-compliant (Unix, Linux, macOS)- Websocket server doesn't shut down with
pnpm dev
process - This solution doesn't seem to work for other content scripts, new-tab, etc. except background.
…med from pre-build) instead of .ts directly
…for fix POSIX-compliant machines and handle errors during wss runtime
…eloadServer.ts and rename it to `cleanIsDevFromBundleOnNodeProcessEnd`
f9a4262
to
71786fa
Compare
@Jonghakseo Now it should work everywhere. I've tested it and it's shutting down with |
This appears to be a timing issue. I was wondering if dist/background might not be present when the hmr module is running. |
@Jonghakseo I can't reproduce it. If yes, then give me steps to reproduce. |
Priority*
Purpose of the PR*
I want to avoid displaying error message of ws from #477 issue
Changes*
I've created func which edit IS_DEV var on dist/background.js file on node process termination, for avoid ws reconnecting after WSS server were stopped because of script interruption
How to check the feature
pnpm dev
orpnpm dev:firefox
CTRL + C
in terminal