Bug fixes #134
Merged
Bug fixes #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YouKnowJoey
reviewed
Jul 1, 2024
home-choice-pro/views/main_window.py
Outdated
| self.setWindowTitle("Home Choice Pro") | ||
| self.guide = self.open_guide() | ||
| self.ui.guideLabel.setText(self.guide) | ||
| self.pmi_warned = False | ||
| self.not_pmi_warned = True |
There was a problem hiding this comment.
'not_pmi_warned'? A more intuitive way to write this would be 'pmi_error_alerted = False'
There was a problem hiding this comment.
Good idea, but for the conditional statement, either both need to be true or both false. This seemed logical but I can look again.
YouKnowJoey
reviewed
Jul 1, 2024
home-choice-pro/views/main_window.py
Outdated
| message = "Private Mortage Insurance typically required with down payments less than 20 percent" | ||
| QMessageBox.warning(self, "PMI Error", message) | ||
| self.pmi_warned = True | ||
| self.not_pmi_warned = False |
There was a problem hiding this comment.
'pmi_error_alerted = True' ; this insinuates that the error message has alerted the user.
YouKnowJoey
reviewed
Jul 1, 2024
| self.ui.PMIEdit.text(), | ||
| ) | ||
| calc = af_calc() | ||
| calc.process_affordability(*self.parameters) |
There was a problem hiding this comment.
I like this! A very clean way to call the calc pass the argument to the object.
There was a problem hiding this comment.
Thanks. I think need to think about a way to guarantee the argument order.
YouKnowJoey
reviewed
Jul 1, 2024
|
Good idea for the gui enhancements. |
randy-shreeves
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors the backend, and solves a lot of bugs.