Weekly Release PR #135
Merged
Weekly Release PR #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated affordability_calculator.py to calculate prices when an HOA fee is included. Verified results against bankrate.com calculators. Updated test cases in test_affordability_calculator.py and verified all tests passed.
Set all variables in affordability_calculator constructor to default to "0". Created a test case for a scenario where user does not enter information, so the constructor defaults the values to "0".
Add HOA fee calculator logic for issue #72
See: #84 Fixed frame style - attempt Windows resize issue fix
Adjusted calculation functions in affordability_calculator.py to return numbers rather than Strings. Also adjusted the test cases to test for numbers rather than Strings and ensured all tests passed.
Backend returns numbers
Improve scaling issues on Windows
Updated affordability_calculator.py with changes to factor user-inputted propery tax rate into calculating a home price that fits within their desired monthly payment. Also updated test cases accordingly and ensured all test cases passed.
…on. Added fFAQ section.
Adjusted affordability_calculator.py to include calculations that factor homeowners insurance into home affordability price. Adjusted test file to accomodate changes and verified all tests passed. Calculations were compared against https://usmortgagecalculator.org/ mortgage calculator.
Adjusted affordability_calculator.py function to test if the home_affordability class variable is 0 before attempting to divide. Verified test cases still pass after making adjustment.
Removed error window class, replaced with simple pop up
Resolved issue #115: Divide by zero error
Resolved: #117, fixed bug preventing dp reset
Restructured content so it flows from application specific information at the top to more general software information towards the bottom. Formatted document so that headers and bullet points are more uniform in appearance. Removed content that seems redundant.
User guide edit
YouKnowJoey
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.