Support HTML bodies #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshData
reviewed
Jul 3, 2024
Comment on lines
-405
to
+414
| return value.decode("utf16") | ||
| decoded = value.decode("utf16") | ||
| # do c-style strings get encoded as utf16? | ||
| # is there an off-by-one error in the variable length math? | ||
| decoded = decoded.removesuffix('\x00') |
Owner
There was a problem hiding this comment.
I would be curious to know more about what might be going on here.
Earlier we have a value_length field that is ignored because we use the whole embedded stream. Maybe it can't be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An bare bones alternative if PR #29 is too much at once