Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align wash_scheme=None signature and insert W; in Evo case #79

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Jul 17, 2024

  • 🐛 Fixes the transfer method signatures to align between BaseWorklist, EvoWorklist, FluentWorklist.
  • ✨ New Worklist(diti_mode=True|False) was introduced to switch to W;-only wash schemes when using DiTis (closes Compatability with DiTi Evos #77)
  • transfer(wash_scheme=...) options changed such that:
    • One of {1, 2, 3, 4} selects a wash scheme for fixed tips, or drops tips when using DiTis.
    • "flush" blows out tips, but does not drop DiTis, and only does a short wash with fixed tips.
    • "reuse" continues pipetting without flushing, dropping or washing.
    • Passing wash_scheme=None is deprecated, because it resulted in "flush" for Fluent and "reuse" for EVO worklists.

Replaces #78

@michaelosthege michaelosthege self-assigned this Jul 17, 2024
@NikolasvdEichen
Copy link

There is a misunderstanding here: What I suggested is that wash_scheme = 0 would insert just a "W;" (not "W1;" or any other number). If wash_scheme = None is passed, just omitting the wash command would still be fine from my point of view

@NikolasvdEichen
Copy link

There are two things that we would need to achieve there, one would be to allow a diti evo to replace its tips in the first place (requires a "W;" on our machine), and the other (stretch goal for me at this point), would be to allow it to pipette multiple times with the same tips - probably requiring a "F;", just like the fluent does. However, naturally the first bit would be more crucial.

michaelosthege and others added 2 commits July 18, 2024 19:07
New options are limited to:
* 1, 2, 3, 4 for wash scheme numbers
* "flush" for inserting a `F;`
* "reuse" for not inserting anything
Copy link

@BioAutomation BioAutomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • everythink ok and clear

@michaelosthege michaelosthege merged commit 525a9c8 into master Jul 19, 2024
6 checks passed
@michaelosthege michaelosthege deleted the issue-77 branch July 19, 2024 14:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatability with DiTi Evos
3 participants