Add tests

spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/ConstructorThrowTest.java

@@ -124,6 +124,13 @@ void testConstructorThrowCheck16() {
         assertCTBugInLine(10);
     }
 
+    @Test
+    void testConstructorThrowCheck17() {
+        performAnalysis("constructorthrow/ConstructorThrowTest17.class");
+        assertNumOfCTBugs(1);
+        assertCTBugInLine(9);
+    }
+
     @Test
     void testGoodConstructorThrowCheck1() {
         performAnalysis("constructorthrow/ConstructorThrowNegativeTest1.class");
@@ -203,6 +210,18 @@ void testGoodConstructorThrowCheck13() {
         assertNumOfCTBugs(0);
     }
 
+    @Test
+    void testGoodConstructorThrowCheck14() {
+        performAnalysis("constructorthrow/ConstructorThrowNegativeTest14.class");
+        assertNumOfCTBugs(0);
+    }
+
+    @Test
+    void testGoodConstructorThrowCheck15() {
+        performAnalysis("constructorthrow/ConstructorThrowNegativeTest15.class");
+        assertNumOfCTBugs(0);
+    }
+
     private void assertNumOfCTBugs(int num) {
         final BugInstanceMatcher bugTypeMatcher = new BugInstanceMatcherBuilder()
                 .bugType("CT_CONSTRUCTOR_THROW").build();

spotbugsTestCases/src/java/constructorthrow/ConstructorThrowNegativeTest14.java

@@ -0,0 +1,23 @@
+package constructorthrow;
+
+/**
+ * The Exception is thrown before the java.lang.Object constructor exits, so this is compliant, since in this case
+ * the JVM will not execute an object's finalizer.
+ * @see <a href="https://github.com/spotbugs/spotbugs/issues/2710">GitHub issue</a>
+ */
+public class ConstructorThrowNegativeTest14 {
+    public ConstructorThrowNegativeTest14() {
+        this(verify());
+    }
+
+    private ConstructorThrowNegativeTest14(boolean secure) {
+        // secure is always true
+        // Constructor without any checks
+    }
+
+    private static boolean verify() {
+        // Returns true if data entered is valid, else throws an Exception
+        // Assume that the attacker just enters invalid data, so this method always throws the exception
+        throw new RuntimeException("Invalid data!");
+    }
+}

spotbugsTestCases/src/java/constructorthrow/ConstructorThrowNegativeTest15.java

@@ -0,0 +1,27 @@
+package constructorthrow;
+
+/**
+ * The isInitialized flag set by the constructor, and the exception is thrown by not the constructor depending on its value.
+ */
+public class ConstructorThrowNegativeTest15 {
+    private volatile boolean isInitialized = false;
+
+    public ConstructorThrowNegativeTest15() {
+        if (!verify()) {
+            return;
+        }
+
+        this.isInitialized = true;
+    }
+
+    private boolean verify() {
+        return false;
+    }
+
+    public void doSomething () {
+        if (!this.isInitialized) {
+            throw new RuntimeException();
+        }
+        // do something
+    }
+}

spotbugsTestCases/src/java/constructorthrow/ConstructorThrowTest17.java

@@ -0,0 +1,16 @@
+package constructorthrow;
+
+/**
+ * The constructor throws an Exception conditionally.
+ */
+public class ConstructorThrowTest17 {
+    public ConstructorThrowTest17() {
+        if (!verify()) {
+            throw new RuntimeException();
+        }
+    }
+
+    private boolean verify() {
+        return false;
+    }
+}