add more test for BadVisibilityOnSharedPrimitiveVariables

spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/BadVisibilityOnSharedPrimitiveVariablesTest.java

@@ -13,6 +13,13 @@ void failurePath_fieldWithBadVisibility_whenOtherMethodHasSynchronizedBlock() {
         assertBugInMethodAtLine(BUG_TYPE, "SynchronizedBlockAndBadVisibilityOnField", "shutdown", 17);
     }
 
+    @Test
+    void failurePath_fieldWithBadVisibility_whenMethodHasIrrelevantSynchronizedBlock() {
+        performAnalysis("multithreaded/sharedPrimitiveVariables/SynchronizedBlockWithBadVisibilityOnField.class");
+        assertBugTypeCount(BUG_TYPE, 1);
+        assertBugInMethodAtLine(BUG_TYPE, "SynchronizedBlockWithBadVisibilityOnField", "shutdown", 20);
+    }
+
     @Test
     void failurePath_fieldWithBadVisibility_whenOtherMethodIsSynchronized() {
         performAnalysis("multithreaded/sharedPrimitiveVariables/SynchronizedMethodAndBadVisibilityOnField.class");

spotbugsTestCases/src/java/multithreaded/sharedPrimitiveVariables/SynchronizedBlockWithBadVisibilityOnField.java

@@ -0,0 +1,22 @@
+package multithreaded.sharedPrimitiveVariables;
+
+public class SynchronizedBlockWithBadVisibilityOnField {
+    private boolean done = false;
+
+    public void run() {
+        synchronized (SynchronizedBlockWithBadVisibilityOnField.class) {
+            System.out.println("this is synchronized, but not the whole method");
+        }
+        while (!done) {
+            try {
+                Thread.currentThread().sleep(1000);
+            } catch(InterruptedException ie) {
+                Thread.currentThread().interrupt();
+            }
+        }
+    }
+
+    public void shutdown() {
+        done = true;
+    }
+}