forked from spotbugs/spotbugs
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
8 changed files
with
192 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
spotbugs-tests/src/test/java/edu/umd/cs/findbugs/LoadMessagesTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Contributions to SpotBugs | ||
| * Copyright (C) 2019, The SpotBugs authors | ||
| * | ||
| * This library is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation; either | ||
| * version 2.1 of the License, or (at your option) any later version. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public | ||
| * License along with this library; if not, write to the Free Software | ||
| * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
| */ | ||
|
|
||
| package edu.umd.cs.findbugs; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.fail; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.io.Reader; | ||
| import java.net.URL; | ||
|
|
||
| import org.dom4j.DocumentException; | ||
| import org.dom4j.io.SAXReader; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import edu.umd.cs.findbugs.charsets.UTF8; | ||
| import edu.umd.cs.findbugs.io.IO; | ||
| import edu.umd.cs.findbugs.xml.XMLUtil; | ||
|
|
||
| /** | ||
| * @author gtoison | ||
| * | ||
| */ | ||
| class LoadMessagesTest { | ||
|
|
||
| @Test | ||
| void loadMessages() { | ||
| loadMessages("/messages.xml"); | ||
| loadMessages("/messages_fr.xml"); | ||
| loadMessages("/messages_ja.xml"); | ||
| } | ||
|
|
||
| private void loadMessages(String fileName) { | ||
| URL messageURL = PluginLoader.class.getResource(fileName); | ||
| SAXReader reader = XMLUtil.buildSAXReader(); | ||
| try (InputStream input = IO.openNonCachedStream(messageURL); | ||
| Reader stream = UTF8.bufferedReader(input)) { | ||
| reader.read(stream); | ||
| } catch (IOException | DocumentException e) { | ||
| fail("Failed to load messages from file " + fileName, e); | ||
| } | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/Issue2379Test.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package edu.umd.cs.findbugs.detect; | ||
|
|
||
| import static edu.umd.cs.findbugs.test.CountMatcher.containsExactly; | ||
| import static org.hamcrest.MatcherAssert.assertThat; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import edu.umd.cs.findbugs.AbstractIntegrationTest; | ||
| import edu.umd.cs.findbugs.test.matcher.BugInstanceMatcher; | ||
| import edu.umd.cs.findbugs.test.matcher.BugInstanceMatcherBuilder; | ||
|
|
||
|
|
||
| public class Issue2379Test extends AbstractIntegrationTest { | ||
| @Test | ||
| public void test() { | ||
| performAnalysis("ghIssues/Issue2379.class"); | ||
|
|
||
| // Check that we've found the uncalled `unusedValues` private method | ||
| BugInstanceMatcher bugTypeMatcher = new BugInstanceMatcherBuilder() | ||
| .bugType("UPM_UNCALLED_PRIVATE_METHOD") | ||
| .inMethod("unusedValues") | ||
| .build(); | ||
|
|
||
| assertThat(getBugCollection(), containsExactly(1, bugTypeMatcher)); | ||
|
|
||
| // Check that it was the one and only bug we've found | ||
| bugTypeMatcher = new BugInstanceMatcherBuilder() | ||
| .bugType("UPM_UNCALLED_PRIVATE_METHOD") | ||
| .build(); | ||
|
|
||
| assertThat(getBugCollection(), containsExactly(1, bugTypeMatcher)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| package ghIssues; | ||
|
|
||
| import java.util.stream.Stream; | ||
|
|
||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
|
|
||
| public class Issue2379 { | ||
| // Compliant, used as source method for the 'test' method | ||
| private static Stream<String> values() { | ||
| return Stream.of("one", "two"); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("values") | ||
| public void test(String value) { | ||
| } | ||
|
|
||
|
|
||
| // Compliant, used as source method for the 'defaultValues' method | ||
| private static int[] defaultValues() { | ||
| return new int[] {1, 2}; | ||
| } | ||
|
|
||
| /** | ||
| * No 'value' in MethodSource so JUnit defaults to a source method with the same name | ||
| */ | ||
| @ParameterizedTest | ||
| @MethodSource | ||
| public void defaultValues(int value) { | ||
| } | ||
|
|
||
|
|
||
| // Compliant, used as source method for the 'multipleSourcesTest' method | ||
| private static Stream<String> valuesFromStream() { | ||
| return Stream.of("one", "two"); | ||
| } | ||
|
|
||
|
|
||
| // Compliant, used as source method for the 'multipleSourcesTest' method | ||
| private static String[] valuesFromArray() { | ||
| return new String[] { "three", "four" }; | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource({"valuesFromStream", "valuesFromArray"}) | ||
| public void multipleSourcesTest(String value) { | ||
| } | ||
|
|
||
| // Non compliant, uncalled private method | ||
| private Stream<String> unusedValues(int x) { | ||
| return Stream.of("one", "two"); | ||
| } | ||
| } |