Handle polymorphic signatures when finding methods (spotbugs#3311)

* test: reproducer for issue spotbugs#3309

* fix: handle polymorphic methods when finding a method descriptor

* doc: added changelog entry

CHANGELOG.md

@@ -11,6 +11,7 @@ Currently the versioning policy of this project follows [Semantic Versioning v2.
 - Fixed html bug descriptions for AT_STALE_THREAD_WRITE_OF_PRIMITIVE and AT_NONATOMIC_64BIT_PRIMITIVE ([#3303](https://github.com/spotbugs/spotbugs/issues/3303))
 - Fixed an `HSM_HIDING_METHOD` false positive when ECJ generates a synthetic method for an enum switch ([#3305](https://github.com/spotbugs/spotbugs/issues/3305))
 - Fix `AT_UNSAFE_RESOURCE_ACCESS_IN_THREAD` false negatives, detector depending on method order.
+- Fix `THROWS_METHOD_THROWS_CLAUSE_THROWABLE` reported in a method calling `MethodHandle.invokeExact` due to its polymorphic signature ([#3309](https://github.com/spotbugs/spotbugs/issues/3309))
 
 ## 4.9.1 - 2025-02-02
 ### Added

spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/Issue3309Test.java

@@ -0,0 +1,14 @@
+package edu.umd.cs.findbugs.detect;
+
+import edu.umd.cs.findbugs.AbstractIntegrationTest;
+import org.junit.jupiter.api.Test;
+
+class Issue3309Test extends AbstractIntegrationTest {
+
+    @Test
+    void testIssue() {
+        performAnalysis("ghIssues/Issue3309.class");
+
+        assertNoBugInClass("THROWS_METHOD_THROWS_CLAUSE_THROWABLE", "Issue3309");
+    }
+}

spotbugs/src/main/java/edu/umd/cs/findbugs/ba/UnresolvedXMethod.java

@@ -302,5 +302,8 @@ public boolean usesInvokeDynamic() {
         return false;
     }
 
-
+    @Override
+    public boolean hasPolymorphicSignature() {
+        return false;
+    }
 }

spotbugs/src/main/java/edu/umd/cs/findbugs/ba/XMethod.java

@@ -212,6 +212,9 @@ public interface XMethod extends ClassMember, AnnotatedObject, ComparableMethod
 
     boolean usesInvokeDynamic();
 
-
-
+    /**
+     * See <code>java.lang.invoke.MethodHandle.PolymorphicSignature</code>
+     * @return is this method polymorphic as defined in {@link java.lang.invoke.MethodHandle}
+     */
+    boolean hasPolymorphicSignature();
 }

spotbugs/src/main/java/edu/umd/cs/findbugs/classfile/analysis/ClassInfo.java

@@ -322,8 +322,9 @@ public List<? extends XMethod> getXMethodsInCallOrder() {
     public XMethod findMethod(String methodName, String methodSig, boolean isStatic) {
         int hash = FieldOrMethodDescriptor.getNameSigHashCode(methodName, methodSig);
         for (MethodInfo mInfo : xMethods) {
-            if (mInfo.getNameSigHashCode() == hash && mInfo.getName().equals(methodName)
-                    && mInfo.getSignature().equals(methodSig) && mInfo.isStatic() == isStatic) {
+            if (mInfo.getName().equals(methodName)
+                    && mInfo.isStatic() == isStatic
+                    && ((mInfo.getNameSigHashCode() == hash && mInfo.getSignature().equals(methodSig)) || mInfo.hasPolymorphicSignature())) {
                 return mInfo;
             }
         }

spotbugs/src/main/java/edu/umd/cs/findbugs/classfile/analysis/MethodInfo.java

@@ -231,6 +231,8 @@ public void setUsesInvokeDynamic() {
 
     final boolean isStub;
 
+    final boolean hasPolymorphicSignature;
+
     final String methodSourceSignature;
 
     final @CheckForNull String[] exceptions;
@@ -318,6 +320,17 @@ public static IdentityHashMap<MethodInfo, Void> getInvokeDynamicMethods() {
         this.isStub = isStub;
         this.methodCallCount = methodCallCount;
         this.variableIsSynthetic = variableIsSynthetic;
+        this.hasPolymorphicSignature = computeHasPolymorphicSignature(methodAnnotations);
+    }
+
+    private boolean computeHasPolymorphicSignature(Map<ClassDescriptor, AnnotationValue> methodAnnotations) {
+        for (ClassDescriptor annotationDescriptor : methodAnnotations.keySet()) {
+            if ("java.lang.invoke.MethodHandle$PolymorphicSignature".equals(annotationDescriptor.getDottedClassName())) {
+                return true;
+            }
+        }
+
+        return false;
     }
 
     @Override
@@ -693,4 +706,9 @@ public XMethod resolveAccessMethodForMethod() {
         }
         return this;
     }
+
+    @Override
+    public boolean hasPolymorphicSignature() {
+        return hasPolymorphicSignature;
+    }
 }

spotbugsTestCases/src/java/ghIssues/Issue3309.java

@@ -0,0 +1,9 @@
+package ghIssues;
+
+import java.lang.invoke.MethodHandle;
+
+public class Issue3309 {
+	public Object newInstance(MethodHandle methodHandle, Object builder, Object cacheLoader, boolean async) throws Throwable {
+		return methodHandle.invokeExact(builder, cacheLoader, async);
+	}
+}