modify test to check every property

JuditKnoll · Oct 25, 2023 · cf27631 · cf27631
1 parent 157d898
commit cf27631
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/UnnecessaryEnvUsageTest.java b/spotbugs-tests/src/test/java/edu/umd/cs/findbugs/detect/UnnecessaryEnvUsageTest.java
@@ -12,11 +12,21 @@
 
 class UnnecessaryEnvUsageTest extends AbstractIntegrationTest {
     @Test
-    void testingVariuosEnvUsages() {
+    void testingEnvUsages() {
         performAnalysis("UnnecessaryEnvUsage.class");
-        assertBug(2);
+        assertBug(12);
         assertBug("replaceableEnvUsage", 3);
         assertBug("replaceableEnvUsage", 4);
+        assertBug("replaceableEnvUsage", 5);
+        assertBug("replaceableEnvUsage", 6);
+        assertBug("replaceableEnvUsage", 7);
+        assertBug("replaceableEnvUsage", 8);
+        assertBug("replaceableEnvUsage", 9);
+        assertBug("replaceableEnvUsage", 10);
+        assertBug("replaceableEnvUsage", 11);
+        assertBug("replaceableEnvUsage", 12);
+        assertBug("replaceableEnvUsage", 13);
+        assertBug("replaceableEnvUsage", 14);
     }
 
     private void assertBug(int num) {

diff --git a/spotbugsTestCases/src/java/UnnecessaryEnvUsage.java b/spotbugsTestCases/src/java/UnnecessaryEnvUsage.java
@@ -1,7 +1,17 @@
 public class UnnecessaryEnvUsage {
     public void replaceableEnvUsage() {
+        System.getenv("JAVA_HOME");
+        System.getenv("JAVA_VERSION");
+        System.getenv("TEMP");
+        System.getenv("TMP");
+        System.getenv("PROCESSOR_ARCHITECTURE");
+        System.getenv("OS");
         System.getenv("USER");
         System.getenv("USERNAME");
+        System.getenv("HOME");
+        System.getenv("HOMEPATH");
+        System.getenv("CD");
+        System.getenv("PWD");
     }
 
     public void necessaryEnvUsage() {