Skip to content

Fixed promote rule bug #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed promote rule bug #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf0892a
Fixed promote rule bug
kaandocal Sep 2, 2021
6270127
Added promote rule test
Apr 9, 2022
59b7b91
Merge branch 'upstream'
Apr 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/promote.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ end
function promote_rule_constant(::Type{S}, PT::Type{<:APL{T}}) where {S, T}
return polynomialtype(PT, promote_type(S, T))
end
Base.promote_rule(::Type{PT}, ::Type{T}) where {T, PT<:APL} = promote_rule_constant(T, PT)
Base.promote_rule(::Type{T}, ::Type{PT}) where {T, PT<:APL} = promote_rule_constant(T, PT)
# Resolve method ambiguity with Base:
Base.promote_rule(::Type{Any}, ::Type{<:APL}) = Any
Expand Down
2 changes: 2 additions & 0 deletions test/promote.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
@test Y[2] == 2x + 4y
@test dot(X, [1 2; 3 4] * X) == x^2 + 5x*y + 4y^2

@test typeof(promote_type(Any, typeof(MP.changecoefficienttype(x + 1, Any)))) == Any

function _t(a, b, T)
if VERSION < v"1.6"
@test typeof(@inferred vcat(a, b)) in [Vector{T}, Vector{Any}]
Expand Down