Skip to content

fix: handle non-concrete polynomials in polynomial_merge! #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

fix: handle non-concrete polynomials in polynomial_merge! #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd5eba0
fix: handle non-concrete polynomials in `polynomial_merge!`
AayushSabharwal Aug 19, 2025
3dd6a05
test: mark test as no longer broken
AayushSabharwal Sep 17, 2025
3e66644
test: run non-concrete polynomial GCD test only for DynamicPolynomials
AayushSabharwal Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/operators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ function polynomial_merge!(
combine::F6,
keep::F7,
resize::F8,
) where {F1,F2,F3,F4,F5,F6,F7,F8}
::Type{term_type} = n1 > 0 ? typeof(get1(1)) :
n2 > 0 ? typeof(get2(1)) : Nothing,
) where {F1,F2,F3,F4,F5,F6,F7,F8,term_type}
buffer = nothing
i = j = k = 1
# Invariant:
Expand All @@ -109,7 +111,7 @@ function polynomial_merge!(
if k == i
t0 = get1(i)
if buffer === nothing
buffer = DataStructures.Queue{typeof(t0)}()
buffer = DataStructures.Queue{term_type}()
end
push!(buffer, t0)
i += 1
Expand Down
2 changes: 1 addition & 1 deletion test/commutative/complex.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
@test !isconj(a)
@test ordinary_variable(a) == a
@test conj(a) == real(a) == a
@test_broken iszero(imag(a)) # no iszero for MA.Zero
@test iszero(imag(a))
@test isreal(a^3 + 5a^2 + 4a)
@test !isreal(a^3 + 5im * a^2 + 4a)

Expand Down
15 changes: 8 additions & 7 deletions test/commutative/gcd.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,14 +291,15 @@ end
end
end
end
@testset "Non-concrete polynomial GCD" begin
Mod.@polyvar p q
p1 = MP.polynomial(p^2 + q^2, Number)
p2 = MP.polynomial(p * q, Number)
g = @inferred gcd(p1, p2)
@test isone(g)
if nameof(Mod) == :DynamicPolynomials
@testset "Non-concrete polynomial GCD" begin
Mod.@polyvar p q
p1 = MP.polynomial(p^2 + q^2, Number)
p2 = MP.polynomial(p * q, Number)
g = @inferred gcd(p1, p2)
@test isone(g)
end
end

@testset "Complex coefficient GCD" begin
Mod.@polyvar p q
p1 = MP.polynomial(p^2 + q^2, ComplexF64)
Expand Down