Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(nufft): Impossible type restriction for nufft2 #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gwater
Copy link

@gwater gwater commented Jan 28, 2021

It was impossible to run nufft2 because the input has to be real and complex at the same time.

It was impossible to run nufft2 because the input has to be real and complex at the same time.
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #131 (cb98aac) into master (8625a44) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   78.41%   78.41%           
=======================================
  Files          13       13           
  Lines        1543     1543           
=======================================
  Hits         1210     1210           
  Misses        333      333           
Impacted Files Coverage Δ
src/nufft.jl 94.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8625a44...cb98aac. Read the comment docs.

@MikaelSlevinsky
Copy link
Member

Looks like a lot of the NUFFT type parameterizations are a bit ad hoc.

Some of the executions would benefit from another type parameter, such as

function mul!(f::AbstractVector{T}, P::NUFFTPlan{1,T}, c::AbstractVector{T}) where {T}

and others would benefit from removing type parameters entirely
function mul!(F::Matrix{T}, P::NUFFTPlan{N,T}, C::Matrix{T}) where {N,T}

Would you mind going through the files (nufft.jl and inufft.jl) to check cases in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants