Support values::AbstractDict
#25
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 48 56 +8
=========================================
+ Hits 48 56 +8
Continue to review full report at Codecov.
|
|
BTW, do you think it's the scope of this package to also handle "(lazy) big thunks" of indices JuliaImages/ImageCore.jl#170 (comment)? |
|
You mean specifically the chroma-subsampling? I've not put enough thought into it to say for certain, but it seems a bit different (it's a manipulation of the pixel index rather than the pixel value). |
This is primarily intended for ImageSegmentation, for which the index label is not guaranteed to be contiguous.
|
OK, I switched this to 1.0 and took advantage of the opportunity to drop Julia 0.7. I assume we want to keep 1.0? I'll leave this open for a couple of days, since I know that percolating |
|
Sounds cool to me! |
|
I should have also CCed @tlnagy, but I have already tested TiffImages locally and I know it passes without issue (after bumping the |
This adds support for looking up values in an
AbstractDict, not just anAbstractVector. The main intended consumer is ImageSegmentation, which does not necessarily use adjacent values for its segment labels: https://github.com/JuliaImages/ImageSegmentation.jl/blob/55c1310dbf6158d6fe1ec9fd765213ac5377bfbb/src/core.jl#L13-L14I've bumped this to 0.5.2, but what about just going to 1.0? Even this change is non-breaking, and I'm having a hard time picturing major ways we might break this package in the future.