Add postprocess::Function arg to benchmarkpkg() #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postprocess is a function that takes the results `Benchmarkgroup` and either modifies them or returns a new version. This allows users to inject logic into the benchmarking pipeline, including subtracting two runs, dividing by N, or other such operations.
2 similar comments
NHDaly
force-pushed
the
post-processing
branch
from
2b416dd
to
ad36c98
Compare
|
@jrevels, any chance I could get your input on this? 😄 Thanks! |
jrevels
reviewed
Jan 5, 2019
|
@KristofferC I think this is in good shape to review if you have time! :) It's a pretty small PR, but it unlocks significant more usecases for using For an example, using this |
|
(Also i think the failing coverage is noisy; i definitely do cover that line. I know i've read that coverage has been wonky lately. 😢) |
|
friendly ping! :) This should be good to merge. |
|
Sorry for slow action. |
|
:) No problem. Thanks for the review, @KristofferC! :) Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postprocess is a function that takes the results
Benchmarkgroupandeither modifies them or returns a new version.
This allows users to inject logic into the benchmarking pipeline,
including subtracting two runs, dividing by N, or other such operations.
Fixes #74