Avoid BoundsError in groupzp (#433)

* Avoid `BoundsError` in `groupzp` Fixes #432. * Bump version to 0.7.1
JuliaDSP · Jun 17, 2021 · 44b5117 · 44b5117 · martinholters · Jun 17, 2021
1 parent eb4f8d7
commit 44b5117
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "DSP"
 uuid = "717857b8-e6f2-59f4-9121-6e50c889abd2"
-version = "0.7.0"
+version = "0.7.1"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

diff --git a/src/Filters/coefficients.jl b/src/Filters/coefficients.jl
@@ -322,6 +322,9 @@ function groupzp(z, p)
         groupedz[i] = splice!(z, closest_zero_idx)
         if !isreal(groupedz[i])
             i += 1
+            if closest_zero_idx > length(z)
+                closest_zero_idx = length(z)
+            end
             groupedz[i] = splice!(z, closest_zero_idx)
         end
         i += 1

diff --git a/test/filter_conversion.jl b/test/filter_conversion.jl
@@ -344,3 +344,14 @@ end
         @test coefb(f) == [0.0, 0.0, 1.0]
     end
 end
+
+@testset "issue #432" begin
+    bp1 = 0.75
+    bp2 = 10.0
+    Fsamp = 180
+    responsetype = Bandpass(bp1, bp2; fs = Fsamp)
+    designmethod = Elliptic(11, 0.25, 40)
+    bpass = digitalfilter(responsetype, designmethod)
+    H = SecondOrderSections(bpass) # this shouldn't throw
+    @test H isa SecondOrderSections
+end