Do no use hardcoded mouse rotation upvector

[jaakkor2]

Fixes #76. Before, rotation upvector is hardcoded to (0,0,-1), causing left/right mouse rotation feels unnaturally reversed if upvector is (0,0,-1). After, rotation upvector taken from up_v.

[SimonDanisch]

I tried it out, and I think by funky, I just meant I really don't like rotations that are not around a straight unit upvector. It's just very hard to straighten the vector again (hope my terminology makes sense).
Maybe we should just change the sign according to up_v? I'll play around with it. Another major concern is, that the upvector is hardcoded in general, which makes it hard to change it.

[SimonDanisch]

Ok, I think using Vec3f0(0, 0, sign(up_v[3])) should solve both of our concerns! Try it out and let me know if that's the behaviour you expect.

[jaakkor2]

vec3f0(0, 0, sign(up_v[3])) works for my case very nicely, actually I like it better than up_v. Definitely improvement from vec3f0(0, 0, 1).

If one would want to allow all rotations to be controlled with mouse, up_v would be the best then, since the two above limits the rotation axis to be aligned with z-axis. Depends much on the visualization task at hand, best of course would be to have this configurable.

I believe some funkiness comes from the high rotation speed, the setting I am looking for in the issue JuliaGL/GLVisualize.jl#226 :)

[SimonDanisch]

Do you want to update the PR to use the sign? :)

[jaakkor2]

Hmm, I am signed in, but do not have push access to patch-1 branch.. :( @SimonDanisch , please feel free to make the change.

[SimonDanisch]

huh? But this is your PR? :D well, I can also do the change ;)

[jaakkor2]

Yes, but the patch seems to be now in unknown repository.

[SimonDanisch]

ha, I can't edit it either... Guess I should just close this then and we start from anew!

[jaakkor2]

The reason for the unknown repository is likely that I think I removed the forked repo under my account.

[SimonDanisch]

well I added it to the sd/makie branch ;)

[SimonDanisch]

I should be merging it very soon, just want to figure out how to get some shader cashing, which I disabled for now...