Skip to content
This repository has been archived by the owner on Apr 28, 2021. It is now read-only.

Commit

Permalink
fix bounds
Browse files Browse the repository at this point in the history
  • Loading branch information
@SimonDanisch
SimonDanisch committed Jun 8, 2017
1 parent 577f3e3 commit e3973ee
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions REQUIRE
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
julia 0.5 0.6.0
julia 0.5

Reactive 0.3.0 0.3.7 0.5-
GLAbstraction 0.3.1 0.4
GeometryTypes 0.2 0.3
Reactive 0.5
GLAbstraction 0.3.1 0.5
GeometryTypes 0.2 0.4

GLFW
ModernGL
Expand Down

6 comments on commit e3973ee

@tkelman
Copy link
Contributor

@tkelman tkelman commented on e3973ee Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought reactive 0.3-0.3.6 would work?

@SimonDanisch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started relying on features of Reactive 0.5 - maybe not in GLWindow (yet), but for the sake of my sanity I'd like to keep the bounds consistent across my packages....

@tkelman
Copy link
Contributor

@tkelman tkelman commented on e3973ee Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bounds for a package should reflect what that package depends on, nothing else

@SimonDanisch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't I just handle my own package in a way I feel comfortable with?

@tkelman
Copy link
Contributor

@tkelman tkelman commented on e3973ee Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the consequences of what you're listing here actually match what you're trying to accomplish. I'm describing cases in which they won't.

@SimonDanisch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to be lazy, and I accomplish that by using the same bounds on my packages...
Can we just move on with these small details? This package is probably used by 0 people outside of GLVisualize and really not worth our time even writing these comments.

Please sign in to comment.