Skip to content

Conversation

kshyatt
Copy link
Member

@kshyatt kshyatt commented Oct 6, 2025

cc @KristofferC

Reprise of what we did for GPUArrays and CUDA and AMDGPU

@kshyatt kshyatt requested a review from maleadt October 6, 2025 08:24
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/runtests.jl b/test/runtests.jl
index 28600d3..5ba92dd 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -339,7 +339,7 @@ println("Testing finished in $elapsed")
             Test.push_testset(resp)
             Test.record(o_ts, resp)
             Test.pop_testset()
-        elseif isa(resp, Tuple{Int,Int})
+        elseif isa(resp, Tuple{Int, Int})
             fake = Test.DefaultTestSet(testname)
             for i in 1:resp[1]
                 Test.record(fake, Test.Pass(:test, nothing, nothing, nothing, nothing))
@@ -385,8 +385,12 @@ println("Testing finished in $elapsed")
     for test in tests
         (test in completed_tests) && continue
         fake = Test.DefaultTestSet(test)
-        Test.record(fake, Test.Error(:test_interrupted, test, nothing,
-                                     [("skipped", [])], LineNumberNode(1)))
+        Test.record(
+            fake, Test.Error(
+                :test_interrupted, test, nothing,
+                [("skipped", [])], LineNumberNode(1)
+            )
+        )
         Test.push_testset(fake)
         Test.record(o_ts, fake)
         Test.pop_testset()
@@ -411,7 +415,7 @@ else
                 Test.@with_testset resp begin
                     Test.record(o_ts, resp)
                 end
-            elseif isa(resp, Tuple{Int,Int})
+            elseif isa(resp, Tuple{Int, Int})
                 fake = Test.DefaultTestSet(testname)
                 for i in 1:resp[1]
                     Test.record(fake, Test.Pass(:test, nothing, nothing, nothing, nothing))
@@ -448,7 +452,7 @@ else
                 # the test runner itself had some problem, so we may have hit a segfault,
                 # deserialization errors or something similar.  Record this testset as Errored.
                 fake = Test.DefaultTestSet(testname)
-                Test.record(fake, Test.Error(:nontest_error, testname, nothing, Base.ExceptionStack([(exception=resp,backtrace=[])]), LineNumberNode(1)))
+                Test.record(fake, Test.Error(:nontest_error, testname, nothing, Base.ExceptionStack([(exception = resp, backtrace = [])]), LineNumberNode(1)))
                 Test.@with_testset fake begin
                     Test.record(o_ts, fake)
                 end
@@ -458,7 +462,7 @@ else
     for test in tests
         (test in completed_tests) && continue
         fake = Test.DefaultTestSet(test)
-        Test.record(fake, Test.Error(:test_interrupted, test, nothing, Base.ExceptionStack([(exception="skipped",backtrace=[])]), LineNumberNode(1)))
+        Test.record(fake, Test.Error(:test_interrupted, test, nothing, Base.ExceptionStack([(exception = "skipped", backtrace = [])]), LineNumberNode(1)))
         Test.@with_testset fake begin
             Test.record(o_ts, fake)
         end

@maleadt
Copy link
Member

maleadt commented Oct 6, 2025

Included in #725 (with some additional fixes); sorry for the duplicated effort.

@maleadt maleadt closed this Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.52%. Comparing base (6481ad9) to head (4efcb77).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   75.52%   75.52%           
=======================================
  Files          24       24           
  Lines        3538     3538           
=======================================
  Hits         2672     2672           
  Misses        866      866           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants