adapt_storage
-related improvements
#296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
Int128
andUInt128
when constructing aMtlArray
. (Int128 does not compile #287 (comment))adapt_storage
to only convertFloat64
->Float32
. This also makesBigFloat
no longer get converted to Float32. Add tests for every supported scalar type. (also Int128 does not compile #287 (comment))Closes #287
Closes #289
I can spin off point 3 into its own PR if the other 2 need more discussion.