Fix KernelAbstractions for Unified Memory #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tgymnich
force-pushed
the
ka-unified-mem
branch
from
030ca30
to
378a3eb
Compare
tgymnich
force-pushed
the
ka-unified-mem
branch
from
9581668
to
aa060b1
Compare
maleadt
reviewed
Mar 12, 2024
| @@ -35,20 +35,20 @@ Adapt.adapt_storage(::KA.CPU, a::MtlArray) = convert(Array, a) | |||
|
|
|||
| function KA.copyto!(::MetalBackend, A::MtlArray{T}, B::MtlArray{T}) where T | |||
| if device(dest) == device(src) | |||
| GC.@preserve A B unsafe_copyto!(device(A), pointer(A), pointer(B), length(A); async=true) | |||
| GC.@preserve A B copyto!(A, B) | |||
There was a problem hiding this comment.
Doesn't this just hide the issue? It's a good change, but only fixes the issue because copyto! currently always synchronizes. Ideally it shouldn't for certain copies, like CUDA.jl doesn't for CuArray->CuArray copies: https://github.com/JuliaGPU/CUDA.jl/blob/bb49887198f258ffcb186d81df4a787453428b38/src/array.jl#L622-L633
There was a problem hiding this comment.
Agreed. This should then probably all be handled by MTLBlitCommandEncoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #314