Skip to content

Pass exact through point intersections#395

Open
Maximus-08 wants to merge 2 commits intoJuliaGeo:mainfrom
Maximus-08:issue-167-point-intersection-exact
Open

Pass exact through point intersections#395
Maximus-08 wants to merge 2 commits intoJuliaGeo:mainfrom
Maximus-08:issue-167-point-intersection-exact

Conversation

@Maximus-08
Copy link
Copy Markdown

Summary

  • expose the exact keyword on public intersection_points entrypoints
  • pass exact through intersection(...; target = GI.PointTrait()) to _intersection_points
  • add regression tests for both public point-intersection paths with exact = false

Before this change:

  • _intersection_points(...; exact=...) already supported the keyword
  • intersection_points(...) dropped it
  • intersection(...; target = GI.PointTrait()) also dropped it

That meant users could not control the exact/inexact predicate path from the supported public APIs.

Testing

  • full package test suite passed

Documenter errors like CurrentModule = GeometryOpsCore failing because GeometryOpsCore was not defined in Main during doctest evaluation. This error is also seen in the CI doctest

Copilot AI review requested due to automatic review settings March 31, 2026 04:54
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the exact predicate-mode keyword controllable from the supported public point-intersection APIs, so callers can explicitly choose the exact vs inexact predicate path rather than being forced into the default.

Changes:

  • Exposes exact on intersection_points(...) entrypoints and forwards it down to _intersection_points.
  • Adds exact to intersection(...; target = GI.PointTrait()) by passing it through to the point-intersection implementation.
  • Adds regression tests covering both public point-intersection paths with exact = false.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/methods/clipping/intersection.jl Threads exact through intersection (PointTrait target) and intersection_points to _intersection_points, and updates intersection_points docs.
test/methods/clipping/intersection_points.jl Adds regression tests ensuring exact = false works via both intersection_points and intersection(...; target=PointTrait()).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Avnish Jaltare <avnishjaltare8@gmail.com>
Signed-off-by: Avnish Jaltare <avnishjaltare8@gmail.com>
@Maximus-08 Maximus-08 force-pushed the issue-167-point-intersection-exact branch from 0089319 to 372744a Compare April 2, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants