Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 2, 2025

This pull request changes the compat entry for the CoordRefSystems package from 0.16, 0.17, 0.18 to 0.16, 0.17, 0.18, 0.19.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@mikeingold mikeingold force-pushed the compathelper/new_version/2025-10-02-01-02-31-853-02215786831 branch from 1844df7 to 5e461dc Compare October 2, 2025 01:02
Copy link
Contributor Author

github-actions bot commented Oct 2, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main 99b5535... main / 99b5535...
Differentials/Differential 0.205 ± 0.001 μs 0.205 ± 0.0019 μs 1 ± 0.01
Differentials/Jacobian 0.171 ± 0.001 μs 0.171 ± 0.0009 μs 1 ± 0.0079
Integrals/Segment/Scalar GaussKronrod 0.622 ± 0.01 μs 0.621 ± 0.01 μs 1 ± 0.023
Integrals/Segment/Scalar GaussLegendre 1.69 ± 0.01 μs 1.69 ± 0.01 μs 1 ± 0.0084
Integrals/Segment/Scalar HAdaptiveCubature 0.841 ± 0.081 μs 0.832 ± 0.089 μs 1.01 ± 0.15
Integrals/Segment/Vector GaussKronrod 0.661 ± 0.011 μs 0.661 ± 0.01 μs 1 ± 0.022
Integrals/Segment/Vector GaussLegendre 5 ± 0.37 μs 4.82 ± 0.4 μs 1.04 ± 0.12
Integrals/Segment/Vector HAdaptiveCubature 0.871 ± 0.03 μs 0.871 ± 0.04 μs 1 ± 0.057
Integrals/Sphere/Scalar GaussKronrod 1.13 ± 0.01 μs 1.13 ± 0.01 μs 1 ± 0.012
Integrals/Sphere/Scalar GaussLegendre 1.88 ± 0.012 ms 1.89 ± 0.012 ms 1 ± 0.0088
Integrals/Sphere/Scalar HAdaptiveCubature 0.0483 ± 0.0001 ms 0.048 ± 0.00011 ms 1.01 ± 0.0031
Integrals/Sphere/Vector GaussKronrod 1.16 ± 0.01 μs 1.16 ± 0.01 μs 1 ± 0.012
Integrals/Sphere/Vector GaussLegendre 2.07 ± 0.018 ms 2.07 ± 0.02 ms 0.996 ± 0.013
Integrals/Sphere/Vector HAdaptiveCubature 0.0496 ± 9.9e-05 ms 0.0495 ± 0.0001 ms 1 ± 0.0029
Rules/GaussLegendre 22.5 ± 0.65 μs 22.4 ± 0.61 μs 1 ± 0.04
Specializations/Scalar GaussLegendre/BezierCurve 0.253 ± 0.0072 ms 0.251 ± 0.0072 ms 1.01 ± 0.041
Specializations/Scalar GaussLegendre/Line 8.62 ± 0.19 μs 8.77 ± 0.21 μs 0.983 ± 0.032
Specializations/Scalar GaussLegendre/Plane 0.797 ± 0.0058 ms 0.787 ± 0.002 ms 1.01 ± 0.0078
Specializations/Scalar GaussLegendre/Ray 5.99 ± 0.05 μs 6.11 ± 0.05 μs 0.98 ± 0.011
Specializations/Scalar GaussLegendre/Rope 0.0509 ± 0.00025 ms 0.0513 ± 0.00028 ms 0.992 ± 0.0073
Specializations/Scalar GaussLegendre/Tetrahedron 0.158 ± 0.0008 s 0.16 ± 0.00099 s 0.985 ± 0.0079
Specializations/Scalar GaussLegendre/Triangle 0.702 ± 0.011 ms 0.695 ± 0.01 ms 1.01 ± 0.022
time_to_load 1.61 ± 0.013 s 1.62 ± 0.0076 s 0.99 ± 0.0094
Memory benchmarks
main 99b5535... main / 99b5535...
Differentials/Differential 3 allocs: 0.0938 kB 3 allocs: 0.0938 kB 1
Differentials/Jacobian 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Segment/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Segment/Scalar HAdaptiveCubature 7 allocs: 0.492 kB 7 allocs: 0.492 kB 1
Integrals/Segment/Vector GaussKronrod 2 allocs: 0.0781 kB 2 allocs: 0.0781 kB 1
Integrals/Segment/Vector GaussLegendre 0.307 k allocs: 12.8 kB 0.307 k allocs: 12.8 kB 1
Integrals/Segment/Vector HAdaptiveCubature 6 allocs: 0.688 kB 6 allocs: 0.688 kB 1
Integrals/Sphere/Scalar GaussKronrod 2 allocs: 0.0469 kB 2 allocs: 0.0469 kB 1
Integrals/Sphere/Scalar GaussLegendre 0 allocs: 0 B 0 allocs: 0 B
Integrals/Sphere/Scalar HAdaptiveCubature 7 allocs: 0.648 kB 7 allocs: 0.648 kB 1
Integrals/Sphere/Vector GaussKronrod 2 allocs: 0.0781 kB 2 allocs: 0.0781 kB 1
Integrals/Sphere/Vector GaussLegendre 30 k allocs: 1.22 MB 30 k allocs: 1.22 MB 1
Integrals/Sphere/Vector HAdaptiveCubature 6 allocs: 0.812 kB 6 allocs: 0.812 kB 1
Rules/GaussLegendre 7 allocs: 0.0325 MB 7 allocs: 0.0325 MB 1
Specializations/Scalar GaussLegendre/BezierCurve 23 allocs: 0.75 kB 23 allocs: 0.75 kB 1
Specializations/Scalar GaussLegendre/Line 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Plane 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
Specializations/Scalar GaussLegendre/Ray 21 allocs: 0.938 kB 21 allocs: 0.938 kB 1
Specializations/Scalar GaussLegendre/Rope 0.068 k allocs: 1.62 kB 0.068 k allocs: 1.62 kB 1
Specializations/Scalar GaussLegendre/Tetrahedron 3 M allocs: 0.179 GB 3 M allocs: 0.179 GB 1
Specializations/Scalar GaussLegendre/Triangle 22 allocs: 1.03 kB 22 allocs: 1.03 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d4a49c4) to head (99b5535).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          191       191           
=========================================
  Hits           191       191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…t, (keep existing compat) (#206)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still using CoordRefSystems.jl v0.18. Looks like the Julia servers are not updated yet.

@JoshuaLampert
Copy link
Member

We need to wait until JuliaGeometry/Meshes.jl#1252 is merged and released.

@JoshuaLampert
Copy link
Member

Ok, I think I know why downgrade failed before. Because this is a CompatHelper PR, force_latest_compatible_version is true, which means Downgrade wants to use the oldest possible version, but Pkg.jl is forces to use the latest compatible version. So obviously this fails. This should be fixed with explicitly setting force_latest_compatible_version: false. With the downgrade action v1 this was not an issue because the action changed the Project.toml. So after this change the latest compatible version was the same as the one downgrade used anyway. I'll create a PR in the downgrade action to suggest this setting since IMHO this setting is always needed in v2.

@JoshuaLampert
Copy link
Member

I wanted to wait for a positive response at julia-actions/julia-downgrade-compat#24, but I don't know how long this will take. So are you fine with merging this, @mikeingold?

@mikeingold
Copy link
Collaborator

@JoshuaLampert I'm not sure I totally understand what's going on under the hood here. It looks like Downgrade passes now but that force_latest_compatible_version: false was set. Is this temporarily circumventing Downgrade or Pkg's rules? Either way, I trust your judgement in this subject area so I'll support whichever path you think is best.

@JoshuaLampert
Copy link
Member

force_latest_compatible_version is an argument in the julia-runtest GitHub Action: https://github.com/julia-actions/julia-runtest/blob/a3f37496e4b615530efe32573ddfa6c19712f5e7/action.yml#L19. If it is set to true, tests will always try to use the latest version allowed by the compat bounds. This makes sense for CompatHelper.jl PRs like this one because then you know you actually test the new version proposed by CompatHelper.jl and catch potential errors the new version causes. This is why it's set to true if the PR comes from CompatHelper.jl and to false otherwise.
With Downgrade, however, we want to test the oldest version. So these two things don't play well together, which is why one should always set force_latest_compatible_version: false for Downgrade.

@JoshuaLampert JoshuaLampert merged commit 70b576f into main Oct 9, 2025
12 checks passed
@JoshuaLampert JoshuaLampert deleted the compathelper/new_version/2025-10-02-01-02-31-853-02215786831 branch October 9, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants