-
Notifications
You must be signed in to change notification settings - Fork 5
CompatHelper: bump compat for CoordRefSystems to 0.19, (keep existing compat) #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for CoordRefSystems to 0.19, (keep existing compat) #205
Conversation
1844df7
to
5e461dc
Compare
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 191 191
=========================================
Hits 191 191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t, (keep existing compat) (#206) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is still using CoordRefSystems.jl v0.18. Looks like the Julia servers are not updated yet.
We need to wait until JuliaGeometry/Meshes.jl#1252 is merged and released. |
Ok, I think I know why downgrade failed before. Because this is a CompatHelper PR, |
I wanted to wait for a positive response at julia-actions/julia-downgrade-compat#24, but I don't know how long this will take. So are you fine with merging this, @mikeingold? |
@JoshuaLampert I'm not sure I totally understand what's going on under the hood here. It looks like Downgrade passes now but that |
|
This pull request changes the compat entry for the
CoordRefSystems
package from0.16, 0.17, 0.18
to0.16, 0.17, 0.18, 0.19
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.