Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated bindings RGB4 RGB1 #557

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

dgleich
Copy link
Contributor

@dgleich dgleich commented Oct 20, 2024

This removes the deprecated bindings for RGB4 and RGB1, see discussion:

JuliaIO/ImageMagick.jl#235
and similar fix in ColorTypes.jl
JuliaGraphics/ColorTypes.jl#312

It also requires the new version of ColorTypes in Compat, but that will cause failures until that version is registered.

CC: @ViralBShah, @ararslan

@ViralBShah
Copy link
Contributor

ColorTypes.jl registration PR: JuliaRegistries/General#117694

Let's re-run the CI in an hour or so.

@ViralBShah
Copy link
Contributor

There is an ambiguity test failing:

     Testing Running tests...
Test Failed at /home/runner/work/Colors.jl/Colors.jl/test/runtests.jl:2
  Expression: isempty(detect_ambiguities(Colors))
   Evaluated: isempty(Tuple{Method, Method}[(_convert(::Type{Cout}, ::Type{C1}, ::Type{C1}, c) where {Cout<:Color, C1<:Color} @ ColorTypes ~/.julia/packages/ColorTypes/0RO5O/src/conversions.jl:90, _convert(::Type{Cdest}, ::Type{Odest}, ::Type{Osrc}, g) where {Cdest<:Color, Odest, Osrc<:AbstractGray} @ Colors ~/work/Colors.jl/Colors.jl/src/conversions.jl:75)])

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.75%. Comparing base (f0a508b) to head (4664eb9).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/conversions.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   98.82%   96.75%   -2.08%     
==========================================
  Files          10        9       -1     
  Lines        1281     1295      +14     
==========================================
- Hits         1266     1253      -13     
- Misses         15       42      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor

Commenting out the ambiguity test, everything else runs fine.

@timholy
Copy link
Member

timholy commented Oct 21, 2024

Let me take a crack at fixing the ambiguity.

@timholy
Copy link
Member

timholy commented Oct 21, 2024

Personally I think we should remove the Invalidations workflow, but we can do that later.

@timholy
Copy link
Member

timholy commented Oct 21, 2024

Does this look good to you @ViralBShah? I haven't looked at other PRs. The docbuild failure is unfortunate but is perhaps better fixed separately.

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 21, 2024

The doc changes are formatting related, and should be straightforward to fix separately. We should fix them before tagging the release.

@ViralBShah ViralBShah merged commit 9697129 into JuliaGraphics:master Oct 21, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants