Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node connected to itself with default lifestyle looks not great. #160

Closed
NAThompson opened this issue Nov 9, 2021 · 1 comment
Closed

Node connected to itself with default lifestyle looks not great. #160

NAThompson opened this issue Nov 9, 2021 · 1 comment

Comments

@NAThompson
Copy link

(Firstly this library is awesome, so hopefully this doesn't come across as ungracious.)

If a node is connected to itself in a graph with the default linetype, the graph looks weird. However, if linetype=curve, then the graph looks great yet again.

Proposing to default the linetype to curve for an edge which originates and ends with the same node.
hdavid16 added a commit to hdavid16/GraphPlot.jl that referenced this issue Aug 2, 2022
@hdavid16
Fix JuliaGraphs#160 make self-loop edges curved
f1f2760 
behavior is regardless of the linetype
@hdavid16 hdavid16 mentioned this issue Aug 2, 2022
Closed
hdavid16 added a commit to hdavid16/GraphPlot.jl that referenced this issue Aug 5, 2022
@hdavid16
Merge pull request #4 from hdavid16/self-loops-curve
4c16357 
Fix JuliaGraphs#160 make self-loop edges curved
@hdavid16 hdavid16 mentioned this issue Aug 5, 2022
Merged
@Lecrapouille Lecrapouille mentioned this issue Oct 19, 2022
Closed
@hdavid16
Copy link
Contributor

hdavid16 commented Apr 3, 2023

@NAThompson thank you for this feedback. This is fixed in PR #186, which will hopefully be reviewed someday and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make self-loop edges curved (included in PR #186) hdavid16/GraphPlot.jl
2 participants
@NAThompson @hdavid16