Add requested features #186
Conversation
-distinguish args, kwargs -add missing kwargs
clarify that Cairo is required to visualize in vscode
Checking for System OS was outdated
Now matches gadfly.jl (https://github.com/GiovineItalia/Gadfly.jl/blob/master/src/open_file.jl)
-allow gplothtml to accept same arguments as gplot -allow x/y-locs to be of different type (<: Real)
and minor changes to plots.jl update README
uses Colorant.set_default_graphic_size
-Allow add title -Set title color and size -Set font family for entire plot -Remove unneded Compose objects (the ones with `nothing` as the arg)
behavior is regardless of the linetype
-relevant for plots with curved self-loops and long node labels
Multiple dispatch was messing up because types were not specified for spring layout and `kws` not preceeded by `;`
Add title
Fix JuliaGraphs#160 make self-loop edges curved
Background color
|
@simonschoelly do you want me to split this up into small PRs? This has been sitting here for several months. If I make small PRs would you or someone else review them? Thanks. |
hdavid16
requested review from
simonschoelly and
etiennedeg
and removed request for
simonschoelly and
etiennedeg
|
This is pending for too long and this would greatly improve the situation, we need to merge it. |
|
Realistically I won't have time to review this and I know nothing about GraphPlot so I'm leaving the decision in your hands. My approach is always that some improvement is better than no improvement at all, even if it's not perfect |
|
@hdavid16 Thanks for the PR, and sorry for the excessive delay. |
|
Thanks @etiennedeg . Might be good to go a new patch or minor release with the added features. |
|
Yes, I wonder if we can get #193 in the release, but it will depend on Graphs#376. If it takes too long for someone to review it, I will do a release without it. |
|
@hdavid16 I did a release |
This PR merges the following individual PR's that address feature requests. I merged them to avoid conflicts when rebasing each time a different PR is merged.
#178 - set background color (conflicts with changing plot size; conflict fixed in this PR). Closes issue #172.
#181 - fix bug in shell_layout. Closes issue #149
#182 - set plot size. Closes issues #94 #147 #161
#183 - add plot title. Closes issue #107
#184 - make self-loops curved. Closes issue #160
#185 - fix bug in spring_layout. Closes issue #154
Also fixes the second point in issue #150 by switching the arrows to be triangles.
Also closes issue #95
Also fixes issue #190