Add engine attribute to Graph, and default to 'dot' layout #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsiqueira
force-pushed
the
38-add-engine-attribute
branch
from
fe1cebd
to
465aad4
Compare
|
Hey! I just ran into this issue today. Did you happen to push your changes to a package repo? |
|
Hi @QuantumFractal, not to anything registered, but you can install my branch using |
|
It seems odd to make this a property of the graph itself, rather than an aspect of the display process, but GraphViz itself is somewhat blurry about this, so that's fine I guess. |
Keno
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #38, we noticed that some position-related attributes are not working (e.g., rankdir). Apparently, the code is using the layout "neato", and the layout that we want to use is "dot".
I've added a field to
Graphto allow changing the engine. I don't know the details on GraphViz, so I am not sure how adequate the implementation is.I also changed the default to "dot", but I can change it if desired.
I have created a test and an example on the README.