Fixes for julia v1.0 #12
Conversation
src/LightGraphsMatching.jl
Outdated
| export MatchingResult, maximum_weight_matching, maximum_weight_maximal_matching, minimum_weight_perfect_matching | ||
|
|
||
| """ | ||
| type MatchingResult{T} | ||
| weight::T | ||
| type MatchingResult{U} |
There was a problem hiding this comment.
Why U as type parameter?
We can also change the annotation type -> struct
There was a problem hiding this comment.
I took some inspiration from SimpleWeightedGraphs, where this is the type of the edge-value. I think it is confusing when we use T for weights, as it is usually the vertex type in JuliaGraphs. Not sure if U is the best choice though, might be better to use W or WE or EW.
|
So, |
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
===========================================
- Coverage 100% 56.36% -43.64%
===========================================
Files 4 4
Lines 113 110 -3
===========================================
- Hits 113 62 -51
- Misses 0 48 +48
Continue to review full report at Codecov.
|
|
There actually might be more problems with the macintosh version: #mlewe/BlossomV.jl/issues/11 |
|
coming from slack, I guess the best way to solve mlewe/BlossomV.jl#11 is to switch the building system with BB2 instead of the old BinDeps.jl. |
|
I think we need somebody with a macintosh to fix that, because BlossomV builds fine on linux. |
|
A Mac docker image could do the job too I guess |
|
BB2 works fine: mlewe/BlossomV.jl#15, but the original code has a very disgusting license. I would be very happy to meet those lawyers if they would bother to come to China for the code of a ten-years-old algorithm. (just kidding) |
|
Re: the BlossomVBuilder license: we must stay away from this at all costs, regardless of the likelihood of legal consequences. If it's not a free license, it can't be in JuliaGraphs. |
Co-Authored-By: simonschoelly <sischoel@gmail.com>
Co-Authored-By: simonschoelly <sischoel@gmail.com>
simonschoelly
force-pushed
the
fixes-for-v1.0
branch
from
65d0ae8
to
a151415
Compare
|
BlossomV now works on macs and I just rebased, so afterwards this probably can be merged. |
|
All greed on Travis, merged |
This should get LightGraphsMatching running on Julia v0.7 and v1.0.
It does not address #10