-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote properties on edges too #40
Conversation
@matbesancon @simonschoelly hi guys! I'm sorry to bother you but could anybody please look at my PR? 😅 |
( I must say I do not have any rights/permissions to to accept this PR or whatever, but I am happy to help ) |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 5 5
Lines 382 384 +2
=======================================
+ Hits 377 379 +2
Misses 5 5
|
@gdalle thanks for merging, but above all thanks for your work on this library! 😃 |
You're welcome! Could you maybe try this v0.8.0 with your own code, and see if you can spot any other issues you'd like to address? Since it's a breaking release, if there's more low-hanging fruit I want it |
@gdalle unfortunately, I don't work on that codebase currently (but I might get back to it next year). Anyway, it was only a very simple supplementary visualization to double-check the connectivity of the system, and the quoted labels were all we needed at that point. I don't remember even really using HTML there. Though, maybe I stuck |
Alright then. I'll leave it dormant for some time and if no other issue pops up this month I'll release |
When serializing in the DOT format
MetaGraph
(savedot
function) was putting quotes around (non-XML) property values for vertices but not for edges of a graph. That broke my code when I tried to put labels containing several words on edges of my graph. So I went on and made serialization quote everything save for XML/HTML value in closer accordance with DOT language spec.