Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store RNG instead of seed in iterative layouts #65

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

hexaeder
Copy link
Collaborator

@hexaeder hexaeder commented Jul 4, 2024

allows to customize DEFAULT_RNG[] on a global basis to use stable RNGs in testing of GraphMakie (ref MakieOrg/GraphMakie.jl#190)

@hexaeder hexaeder force-pushed the hw/seedtorng branch 2 times, most recently from a80551f to 5ba24cb Compare July 4, 2024 14:16
allows to customize `DEFAULT_RNG[]` on a global basis to use
stable RNGs
src/sfdp.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link

I just went looking for this feature since our reference image tests that make use of NetworkLayouts failed with the new release of Julia 1.11.

@hexaeder hexaeder merged commit cd20b14 into master Oct 16, 2024
5 checks passed
hexaeder added a commit that referenced this pull request Oct 16, 2024
its much better to pass the rng via iterator state, otherwise
both identical positions get the same random force thus move
in the same direction. This was messing up an example in the docs
@hexaeder hexaeder mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants