Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on lts and pre #190

Merged
merged 4 commits into from
Oct 16, 2024
Merged

test on lts and pre #190

merged 4 commits into from
Oct 16, 2024

Conversation

hexaeder
Copy link
Collaborator

@hexaeder hexaeder commented Jul 2, 2024

No description provided.

@hexaeder
Copy link
Collaborator Author

hexaeder commented Jul 4, 2024

Julia 1.11 changes the random streams. Unfortunately, that means basically all ref tests broke. Not sure how to prevent this in the future without cluttering the examples with explicit stable rng code and pass it to the layout kw of every single plot command...

@mtfishman
Copy link

We're facing the same issues in our tests. Besides passing around a StableRNG the other alternative I could think of is having version-dependent reference images, i.e. store one set of images for Julia 1.10, one for Julia 1.11, etc. (I'll do that for now since the StableRNGs.jl approach requires JuliaGraphs/NetworkLayout.jl#65 but I'm not sure how automated it will be, i.e. it will be annoying to have to generate new images for now versions so that ideally should be automated).

@hexaeder hexaeder merged commit c1a2d7d into master Oct 16, 2024
5 checks passed
@hexaeder hexaeder deleted the hw/test_lts_pre branch October 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants