improve HDF5Viewer, add lock for await_finalize #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to add more multithreading to the example HDF5Viewer, I ran into a crash. The code involves populating a GtkTreeModel in a separate thread, which triggers the finalizing code in that thread. Adding a lock around all operations involving the set "await_finalize" fixed it.
Judging by JuliaGraphics/Gtk.jl#694 there is probably a lot more we need to do, but I am not sure what's the best strategy. This fixes my issue so I'll just add this for now.