In gobject_move_ref, replace weak reference with strong reference in gc_preserve_glib
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `gc_preserve_glib` This prevents these objects, which are "subclasses" such as GtkCanvas, from being garbage collected at all. Previously, the code was supposed to intercept the garbage collection and do this "weak to strong" conversion if the object survives being unreferenced by Julia, but #87 seems to indicate a problem. This is a band-aid fix for that issue.
|
This does not stop the CairoSurface from being collected right? As long as those can still be gc'ed, the memory leak shouldn't be too bad (at least for our use case where we don't dynamically create new canvases and only load the UI once per session ideally) |
|
As far as I know the surface should still be GC'd. I'll verify that though. If the widget leak is an issue it might be possible to purposely destroy widgets by deleting them from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents these objects, which are "subclasses" such as GtkCanvas, from being garbage collected. Previously, the code was supposed to intercept the garbage collection and do this "weak to strong" conversion if the object survives being unreferenced by Julia, but #87 seems to indicate a problem. This is a band-aid fix for that issue.
@nHackel @tknopp this seems to fix #87. I will look at consequences in Gtk4Makie and other downstream packages before merging.
This "fix" will probably prevent
GtkCanvasand other subclasses that usegobject_move_reffrom ever being freed. A better fix will have to wait for someone to do a deep dive into the GObject <-> Julia object code.