Skip to content

feat: add Dates #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: add Dates #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0900bbf
docs: add how to install awkward for PyCall.jl
ianna Oct 15, 2023
40b585b
Update src/pycall/README.md
ianna Oct 15, 2023
6eb2360
Update src/pycall/README.md
ianna Oct 15, 2023
bae438c
test: add Dates and other dependencies
ianna Oct 19, 2023
7e56cd4
Merge branch 'main' into ianna/datetime-test
ianna Oct 19, 2023
b3cce9e
remove unneeded dependencies
ianna Nov 15, 2023
1d0b93e
Update README.md
ianna Nov 15, 2023
a2fbf9e
Delete src/pycall/README.md
ianna Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ version = "1.0.0-DEV"

[deps]
JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

[compat]
Expand Down
17 changes: 9 additions & 8 deletions src/AwkwardArray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module AwkwardArray

import JSON
import Dates
import Tables

### Index ################################################################
Expand Down Expand Up @@ -274,10 +275,10 @@ function _to_buffers!(
primitive = "complex64"
elseif ITEM == Complex{Float64}
primitive = "complex128"
# elseif ITEM <: Dates.DateTime # FIXME
# primitive = "datetime64"
# elseif ITEM <: Dates.TimePeriod # FIXME
# primitive = "timedelta64"
elseif ITEM <: DateTime
primitive = "datetime64"
elseif ITEM <: TimePeriod
primitive = "timedelta64"
else
error(
"PrimitiveArray has an ITEM type that can't be serialized in the to_buffers protocol: $ITEM",
Expand Down Expand Up @@ -3117,10 +3118,10 @@ function from_buffers(
data = reinterpret(Complex{Float32}, buffer)
elseif primitive == "complex128"
data = reinterpret(Complex{Float64}, buffer)
# elseif primitive == "datetime64"
# FIXME: Dates.DateTime
# elseif primitive == "timedelta64"
# FIXME: Dates.TimePeriod
elseif primitive == "datetime64"
data = reinterpret(DateTime, buffer)
elseif primitive == "timedelta64"
data = reinterpret(TimePeriod, buffer)
else
error(
"unrecognized \"primitive\": $(repr(primitive)) in \"class\": \"$class\" node",
Expand Down