Skip to content

Commit

Permalink
Address breaking change on nightly (#226)
Browse files Browse the repository at this point in the history
* Address breaking change on nightly

Fix to [225](#225)

* Compatibility fix

* Compat to handle Dates

* Added Compat.Dates

* Added Compat.Dates to all files that required it

* Remove isdefined(Base, :Dates) check
  • Loading branch information
Nosferican authored and TotalVerb committed Nov 24, 2017
1 parent 8d5ad9b commit 0b191d9
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion REQUIRE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
julia 0.6
Compat 0.33.0
Compat 0.37.0
1 change: 1 addition & 0 deletions src/Writer.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module Writer

using Compat.Dates
using ..Common
using ..Serializations: Serialization, StandardSerialization,
CommonSerialization
Expand Down
2 changes: 1 addition & 1 deletion test/REQUIRE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
DataStructures
FixedPointNumbers
OffsetArrays
Compat 0.31.0
Compat 0.37.0
5 changes: 2 additions & 3 deletions test/lowering.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ module TestLowering

using JSON
using Compat.Test
using Compat.Dates
using FixedPointNumbers: Fixed

if isdefined(Base, :Dates)
@test JSON.json(Date(2016, 8, 3)) == "\"2016-08-03\""
end
@test JSON.json(Date(2016, 8, 3)) == "\"2016-08-03\""

@test JSON.json(:x) == "\"x\""
@test_throws ArgumentError JSON.json(Base)
Expand Down
1 change: 1 addition & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using JSON
using Compat.Test
using Compat
using Compat.Dates
using OffsetArrays

import DataStructures
Expand Down

0 comments on commit 0b191d9

Please sign in to comment.