Fix writing arrays with unconventional indices

JuliaIO · Sep 2, 2017 · cfd7b19 · cfd7b19
1 parent aad2e25
commit cfd7b19
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/src/Writer.jl b/src/Writer.jl
@@ -315,7 +315,7 @@ Serialize a multidimensional array to JSON in column-major format. That is,
 function show_json{T,n}(io::SC, s::CS, A::AbstractArray{T,n})
     begin_array(io)
     newdims = ntuple(_ -> :, Val{n - 1})
-    for j in 1:size(A, n)
+    for j in indices(A, n)
         show_element(io, s, view(A, newdims..., j))
     end
     end_array(io)

diff --git a/test/REQUIRE b/test/REQUIRE
@@ -1,2 +1,3 @@
 DataStructures
 FixedPointNumbers
+OffsetArrays
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,6 +1,7 @@
 using JSON
 using Base.Test
 using Compat
+using OffsetArrays
 
 import DataStructures
 

diff --git a/test/standard-serializer.jl b/test/standard-serializer.jl
@@ -56,6 +56,7 @@ end
 
     #Multidimensional arrays
     @test json([0 1; 2 0]) == "[[0,2],[1,0]]"
+    @test json(OffsetArray([0 1; 2 0], 0:1, 10:11)) == "[[0,2],[1,0]]"
 end
 
 @testset "Pairs" begin