Fix PR #70 feedback: API cleanup and URL fixes #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
quinnj
commented
Jan 14, 2026
quinnj
commented
- Change validate() to return nothing on success (matches v1.x behavior)
- Extend Base.isvalid instead of exporting custom isvalid
- Restore copyright headers in src/schema.jl
- Remove main branch from CI.yml
- Fix URLs: JuliaServices -> JuliaIO in README.md and docs
- Update migration.md
- Change validate() to return nothing on success (matches v1.x behavior) - Extend Base.isvalid instead of exporting custom isvalid - Restore copyright headers in src/schema.jl - Remove main branch from CI.yml (only master exists) - Fix URLs: JuliaServices -> JuliaIO in README.md and docs - Fix migration.md to reflect actual v2.0 API behavior - Update tests for new validate return type Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
I'll merge this and then open a follow-up PR. I think we can remove some of the compat stuff if we're making a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.