Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed test result for frame rate (fps) #394

Merged
merged 2 commits into from
May 11, 2023
Merged

fixed test result for frame rate (fps) #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b614bd7
fix test results for two files
AbelHo Feb 11, 2023
619a760
fix get_fps to select video stream only
AbelHo Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/testvideos.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const videofiles = Dict(
"https://downloadnatureclip.blogspot.com/p/download-links.html",
"https://archive.org/download/LadybirdOpeningWingsCCBYNatureClip/Ladybird%20opening%20wings%20CC-BY%20NatureClip.mp4",
397,
30000//1,
30000//1001,
13,
3216,
),
Expand Down Expand Up @@ -87,7 +87,7 @@ const videofiles = Dict(
"https://www.eso.org/public/videos/eso1004a/",
"https://upload.wikimedia.org/wikipedia/commons/1/13/Artist%E2%80%99s_impression_of_the_black_hole_inside_NGC_300_X-1_%28ESO_1004c%29.webm",
597,
1000//1,
25//1,
1,
4816,
),
Expand Down
2 changes: 1 addition & 1 deletion test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ Query the container `file` for the frame per second(fps) of the video stream
function get_fps(file::AbstractString, streamno::Integer = 0)
streamno >= 0 || throw(ArgumentError("streamno must be non-negative"))
fps_strs = FFMPEG.exe(
`-v 0 -of compact=p=0 -select_streams 0 -show_entries stream=r_frame_rate $file`,
`-v 0 -of compact=p=0 -select_streams v:$(streamno) -show_entries stream=r_frame_rate $file`,
command = FFMPEG.ffprobe,
collect = true,
)
Expand Down