Mark summarysize test as broken with todo (fixes nightly)#411
Merged
IanButterworth merged 1 commit intomasterfrom Nov 29, 2023
Merged
Mark summarysize test as broken with todo (fixes nightly)#411IanButterworth merged 1 commit intomasterfrom
IanButterworth merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 79.20% 79.20%
=======================================
Files 10 10
Lines 1284 1284
=======================================
Hits 1017 1017
Misses 267 267 ☔ View full report in Codecov by Sentry. |
Member
Author
|
summarysize of a |
|
this is expected. Testing exact summarysize is probably a bad idea. |
Member
Author
|
Thanks. Makes sense. |
568da68 to
c930f7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that PNGFiles is fixed by JuliaIO/PNGFiles.jl#74
The depwarns are an upstream issue JuliaIO/FFMPEG.jl#57
ARMv8 CI seems unhappy but it's not clear if there's anything to fix here