Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark summarysize test as broken with todo (fixes nightly) #411

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Nov 29, 2023

Now that PNGFiles is fixed by JuliaIO/PNGFiles.jl#74

The depwarns are an upstream issue JuliaIO/FFMPEG.jl#57

ARMv8 CI seems unhappy but it's not clear if there's anything to fix here

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe01b63) 79.20% compared to head (c930f7f) 79.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files          10       10           
  Lines        1284     1284           
=======================================
  Hits         1017     1017           
  Misses        267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IanButterworth
Copy link
Member Author

summarysize of a Vector{PermutedDimsArray{RGB{N0f8}, 2, (2, 1), (2, 1), Matrix{RGB{N0f8}}}} is returning a higher value on nightly. Just a guess, but is that an expected Memory{T} change @oscardssmith ?

Reading annie_oakley.ogg: Test Failed at /home/runner/work/VideoIO.jl/VideoIO.jl/test/reading.jl:136
  Expression: Base.summarysize(framestack) == (VideoIO.TestVideos.videofiles[name]).summarysize
   Evaluated: 167337280 == 167311096

@oscardssmith
Copy link

this is expected. Testing exact summarysize is probably a bad idea.

@IanButterworth
Copy link
Member Author

Thanks. Makes sense.

@IanButterworth IanButterworth changed the title Check nightly Mark summarysize test as broken with todo (fixes nightly) Nov 29, 2023
@IanButterworth IanButterworth marked this pull request as ready for review November 29, 2023 17:35
@IanButterworth IanButterworth merged commit bcce440 into master Nov 29, 2023
27 of 30 checks passed
@IanButterworth IanButterworth deleted the ib/nightly_check branch November 30, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants