Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ext args #67

Merged
merged 2 commits into from
May 18, 2024
Merged

Fix ext args #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc8ca60
Fix ext args
JeffFessler May 18, 2024
f37ae66
Add CODECOV_TOKEN
JeffFessler May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ jobs:
if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }}
with:
file: lcov.info
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
1 change: 0 additions & 1 deletion ext/sino-plot.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ Make a scatter plot of the `(r, ϕ)` sample locations for all rays.
Needs `Plots`.
"""
function sino_plot_rays(rg::SinoGeom; kwargs...)
# r, phi = rays(rg)
i = rays(rg)
r = [i[1] for i in i]
ϕ = [i[2] for i in i]
Expand Down
8 changes: 4 additions & 4 deletions src/exts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
export sino_plot_rays, sino_geom_plot!
export ct_geom_plot2!, ct_geom_plot3

sino_plot_rays(::Nothing) = throw("Run `using Plots` first")
sino_geom_plot!(::Nothing) = throw("Run `using Plots` first")
sino_plot_rays(args...; kwargs...) = throw("First run `using Plots`")
sino_geom_plot!(args...; kwargs...) = throw("First run `using Plots`")

ct_geom_plot2!(::Nothing) = throw("Run `using Plots` first")
ct_geom_plot3(::Nothing) = throw("Run `using Plots` first")
ct_geom_plot2!(args...; kwargs...) = throw("First run `using Plots`")
ct_geom_plot3(args...; kwargs...) = throw("First run `using Plots`")
Loading