Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #196

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Update index.md #196

merged 8 commits into from
Aug 16, 2023

Conversation

Jay-sanjay
Copy link
Contributor

I updated the introductory documentation of the ImageCore.jl package , I also added the command to add it to the Julia environment one is using

I updated the introductory documentation of the ImageCore.jl package , I also added the command to add it to the Julia environment one is using
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ebad6c) 76.72% compared to head (14b19d3) 76.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   76.72%   76.72%           
=======================================
  Files           9        9           
  Lines         550      550           
=======================================
  Hits          422      422           
  Misses        128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jay-sanjay
Copy link
Contributor Author

I request the owner of this repository to please merge it in the main branch.

Copy link
Member

@ashwani-rathee ashwani-rathee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to update some details, also BTW methods exported by this package are mentioned and exported here: https://github.com/JuliaImages/ImageCore.jl/blob/master/src/ImageCore.jl

@@ -7,6 +7,22 @@ representations through different "view" types, and to provide some
useful low-level functions (including "traits") that simplify image
display, input/output, and the writing of algorithms.

Some of the key features and functionalities provided by ImageCore.jl include:

1.Image I/O: Loading and saving images in various formats like PNG, JPEG, BMP, TIFF, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image IO support is provided by FileIO.jl and not by this package

1.Image I/O: Loading and saving images in various formats like PNG, JPEG, BMP, TIFF, etc.
2.Image data representation: It provides the Image type to store image data along with functions for basic image manipulation.
3.Resizing and scaling: Functions for resizing and scaling images.
4.Image rotation and flipping: Functions to rotate and flip images.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resizing, scaling, image rotation and flipping are provided by ImageTransformations.jl and exported there

2.Image data representation: It provides the Image type to store image data along with functions for basic image manipulation.
3.Resizing and scaling: Functions for resizing and scaling images.
4.Image rotation and flipping: Functions to rotate and flip images.
5.Basic image processing operations: Some simple image processing operations like converting images to grayscale, computing histograms, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

histograms computation is not provided here, need to update it

4.Image rotation and flipping: Functions to rotate and flip images.
5.Basic image processing operations: Some simple image processing operations like converting images to grayscale, computing histograms, etc.

It is important to note that ImageCore.jl focuses on fundamental image processing operations and may not have the full range of advanced image processing capabilities found in more specialized libraries. For more complex image processing tasks, you might need to explore other Julia packages such as ImageMagick.jl or ImageFiltering.jl, or other external libraries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageMagick.jl provides just IO methods, you can see different packages and their use cases here: https://juliaimages.org/latest/pkgs/

I have made some changes that you suggested . Please do review them once.
I have made some changes as you suggested . Please review it once
Copy link
Member

@ashwani-rathee ashwani-rathee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should define what you are trying to solve and then find all information you could on it by exploring the documentation in this case which would have helped greatly here

docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
Jay-sanjay and others added 2 commits August 5, 2023 10:10
Co-authored-by: Ashwani Rathee <ab669522@gmail.com>
Co-authored-by: Ashwani Rathee <ab669522@gmail.com>
@Jay-sanjay
Copy link
Contributor Author

ohh I am getting the point slowly , how it's done

Copy link
Member

@ashwani-rathee ashwani-rathee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be it

docs/src/index.md Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like useful additions, thanks!

docs/src/index.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Holy <tim.holy@gmail.com>
docs/src/index.md Outdated Show resolved Hide resolved
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@timholy timholy merged commit 2ed7df8 into JuliaImages:master Aug 16, 2023
9 checks passed
@timholy
Copy link
Member

timholy commented Aug 16, 2023

Thanks!

@Jay-sanjay
Copy link
Contributor Author

My Pleasure sir !

@Jay-sanjay Jay-sanjay deleted the patch-1 branch October 24, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants