replace bad threadid buffering #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/task_local
branch
from
8299255
to
1bca287
Compare
IanButterworth
force-pushed
the
ib/task_local
branch
from
1bca287
to
4dc70a1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 94.23% 94.25% +0.02%
==========================================
Files 13 13
Lines 1699 1706 +7
==========================================
+ Hits 1601 1608 +7
Misses 98 98
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265
This is a naive swap out. There may be refactoring that should happen at a higher level with the buffer management.
Untested locally.