Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump package version, CXXWrap, and some small fixes #47

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

ViralBShah
Copy link
Contributor

No description provided.

Project.toml Outdated Show resolved Hide resolved
@ViralBShah
Copy link
Contributor Author

ViralBShah commented Oct 24, 2024

This error in the tests seems to be in downloading opencv_extra, which is an older version being pulled.

  8 dependencies successfully precompiled in 20 seconds. 75 already precompiled.
     Testing Running tests...
     Failure artifact: opencv_extra
 Downloading artifact: opencv_extra

@ViralBShah
Copy link
Contributor Author

ViralBShah commented Oct 24, 2024

And then (which I have tried to fix in this PR):

WARNING: Method definition IOU(Any, Any) in module Main at /Users/viral/.julia/dev/OpenCV/test/test_objdetect.jl:7 overwritten at /Users/viral/.julia/dev/OpenCV/test/test_dnn.jl:3.
OpenCV: Error During Test at /Users/viral/.julia/dev/OpenCV/test/runtests.jl:13
  Got exception outside of a @test
  LoadError: MethodError: no method matching dnn_setInputScale(::OpenCV.DetectionModelAllocated, ::Float64)
  The function `dnn_setInputScale` exists, but no method is defined for this combination of argument types.
  
  Closest candidates are:
    dnn_setInputScale(::OpenCV.Model, ::Union{Tuple{}, Tuple{Number}, Tuple{Number, Number}, Tuple{Number, Number, Number}, NTuple{4, Number}})
     @ OpenCV ~/.julia/artifacts/12890b1eaf53ee776ede25d1cb4b8dba6d1a55ab/OpenCV/src/cv_dnn_cxx_wrap.jl:200
  
  Stacktrace:
    [1] top-level scope
      @ ~/.julia/dev/OpenCV/test/test_dnn.jl:21
    [2] include(fname::String)
      @ Main ./sysimg.jl:38
    [3] macro expansion
      @ ~/.julia/dev/OpenCV/test/runtests.jl:18 [inlined]
    [4] macro expansion
      @ ~/.julia/juliaup/julia-1.11.1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.11/Test/src/Test.jl:1700 [inlined]
    [5] top-level scope
      @ ~/.julia/dev/OpenCV/test/runtests.jl:14
    [6] include(fname::String)
      @ Main ./sysimg.jl:38
    [7] top-level scope
      @ none:6
    [8] eval
      @ ./boot.jl:430 [inlined]
    [9] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:296
   [10] _start()
      @ Base ./client.jl:531
  in expression starting at /Users/viral/.julia/dev/OpenCV/test/test_dnn.jl:21
Test Summary:                   | Pass  Error  Broken  Total  Time
OpenCV                          |   96      1       2     99  3.7s
  Bounds checking               |   18                    18  0.1s
  single CartesianIndex         |   18                    18  0.0s
  mix of CartesianIndex and Int |    8                     8  0.0s
  vector indices                |   15                    15  0.0s
  logical                       |   18                    18  0.1s
  array of CartesianIndex       |   16                    16  0.0s
ERROR: LoadError: Some tests did not pass: 96 passed, 0 failed, 1 errored, 2 broken.
in expression starting at /Users/viral/.julia/dev/OpenCV/test/runtests.jl:13
ERROR: Package OpenCV errored during testing

@ViralBShah ViralBShah changed the title Bump CXXWrap Bump package version, CXXWrap, and some small fixes Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (03b605d) to head (93b50a2).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor Author

A huge thanks to @barche for getting OpenCV.jl running again! Hoping others can help with the maintenance of the package and exposing OpenCV's surface area in the Julia bindings!

@ViralBShah ViralBShah merged commit cfdadf0 into master Oct 24, 2024
10 checks passed
@ViralBShah ViralBShah deleted the vs/update branch October 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants