Allow external consumers to register custom C++ passes

[oscardssmith]

desired for Enzyme.

cc: @gbaraldi @wsmoses

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.

diff --git a/lib/15/libLLVM_extra.jl b/lib/15/libLLVM_extra.jl
index 0204f16d..441166f6 100644
--- a/lib/15/libLLVM_extra.jl
+++ b/lib/15/libLLVM_extra.jl
@@ -372,7 +372,7 @@ function LLVMDisposePassBuilderExtensions(Extensions)
 end
 
 function LLVMPassBuilderExtensionsPushRegistrationCallbacks(Options, RegistrationCallback)
-    ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
+    return ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
 end
 
 # typedef LLVMBool ( * LLVMJuliaModulePassCallback ) ( LLVMModuleRef M , void * Thunk )
diff --git a/lib/16/libLLVM_extra.jl b/lib/16/libLLVM_extra.jl
index 0204f16d..441166f6 100644
--- a/lib/16/libLLVM_extra.jl
+++ b/lib/16/libLLVM_extra.jl
@@ -372,7 +372,7 @@ function LLVMDisposePassBuilderExtensions(Extensions)
 end
 
 function LLVMPassBuilderExtensionsPushRegistrationCallbacks(Options, RegistrationCallback)
-    ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
+    return ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
 end
 
 # typedef LLVMBool ( * LLVMJuliaModulePassCallback ) ( LLVMModuleRef M , void * Thunk )
diff --git a/lib/17/libLLVM_extra.jl b/lib/17/libLLVM_extra.jl
index 485a4912..ee9edb51 100644
--- a/lib/17/libLLVM_extra.jl
+++ b/lib/17/libLLVM_extra.jl
@@ -332,7 +332,7 @@ function LLVMDisposePassBuilderExtensions(Extensions)
 end
 
 function LLVMPassBuilderExtensionsPushRegistrationCallbacks(Options, RegistrationCallback)
-    ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
+    return ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
 end
 
 # typedef LLVMBool ( * LLVMJuliaModulePassCallback ) ( LLVMModuleRef M , void * Thunk )
diff --git a/lib/18/libLLVM_extra.jl b/lib/18/libLLVM_extra.jl
index 36487c40..cc1173eb 100644
--- a/lib/18/libLLVM_extra.jl
+++ b/lib/18/libLLVM_extra.jl
@@ -266,7 +266,7 @@ function LLVMDisposePassBuilderExtensions(Extensions)
 end
 
 function LLVMPassBuilderExtensionsPushRegistrationCallbacks(Options, RegistrationCallback)
-    ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
+    return ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
 end
 
 # typedef LLVMBool ( * LLVMJuliaModulePassCallback ) ( LLVMModuleRef M , void * Thunk )
diff --git a/lib/19/libLLVM_extra.jl b/lib/19/libLLVM_extra.jl
index 36487c40..cc1173eb 100644
--- a/lib/19/libLLVM_extra.jl
+++ b/lib/19/libLLVM_extra.jl
@@ -266,7 +266,7 @@ function LLVMDisposePassBuilderExtensions(Extensions)
 end
 
 function LLVMPassBuilderExtensionsPushRegistrationCallbacks(Options, RegistrationCallback)
-    ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
+    return ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
 end
 
 # typedef LLVMBool ( * LLVMJuliaModulePassCallback ) ( LLVMModuleRef M , void * Thunk )
diff --git a/lib/20/libLLVM_extra.jl b/lib/20/libLLVM_extra.jl
index 50c4c4f6..f5bed765 100644
--- a/lib/20/libLLVM_extra.jl
+++ b/lib/20/libLLVM_extra.jl
@@ -222,7 +222,7 @@ function LLVMDisposePassBuilderExtensions(Extensions)
 end
 
 function LLVMPassBuilderExtensionsPushRegistrationCallbacks(Options, RegistrationCallback)
-    ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
+    return ccall((:LLVMPassBuilderExtensionsPushRegistrationCallbacks, libLLVMExtra), Cvoid, (LLVMPassBuilderExtensionsRef, Ptr{Cvoid}), Options, RegistrationCallback)
 end
 
 # typedef LLVMBool ( * LLVMJuliaModulePassCallback ) ( LLVMModuleRef M , void * Thunk )

[vchuravy]

Needs test?

[oscardssmith]

@gbaraldi or @wsmoses can one of you add the test?

[gbaraldi]

This is tested by the normal tests. Registering the Julia passes does this

[oscardssmith]

I assumed @vchuravy was asking for a test of an external consumer, but would be good to confirm.